From: David Brownell <david-b@pacbell•net>
To: spi-devel-general@lists•sourceforge.net
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [spi-devel-general] [PATCH] [SPI][POWERPC] spi_mpc83xx: fix prescale modulus calculation
Date: Mon, 6 Aug 2007 08:44:40 -0700 [thread overview]
Message-ID: <200708060844.40310.david-b@pacbell.net> (raw)
In-Reply-To: <20070806131014.GA6913@localhost.localdomain>
On Monday 06 August 2007, Anton Vorontsov wrote:
> +
> + if (pm)
> + pm--;
> + else /* this floods dmesg if using mmc_spi, so dbg */
> + dev_dbg(&spi->dev, "Requested speed is too "
> + "high: %d Hz. Will use %d Hz instead.\n",
> + spi->max_speed_hz, mpc83xx_spi->spibrg / 4);
Except that's not worthy of any message whatsoever, so it shouldn't
even be a debug message: user says "give me at most X", driver says
"fine", end of story.
I'm more bothered by the earlier message, which gives a rate higher
than X instead of cleanly failing.
- Dave
next prev parent reply other threads:[~2007-08-06 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 13:10 [PATCH] [SPI][POWERPC] spi_mpc83xx: fix prescale modulus calculation Anton Vorontsov
2007-08-06 15:44 ` David Brownell [this message]
2007-08-06 16:39 ` [spi-devel-general] [PATCH] [SPI][POWERPC] spi_mpc83xx: fix prescale modulus?calculation Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708060844.40310.david-b@pacbell.net \
--to=david-b@pacbell$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=spi-devel-general@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox