* Export DCR symbols - resubmitting
@ 2007-08-08 21:46 Murali Iyer
2007-08-08 21:58 ` [Cbe-oss-dev] " Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Murali Iyer @ 2007-08-08 21:46 UTC (permalink / raw)
To: Linuxppc-dev, cbe-oss-dev
[-- Attachment #1: Type: text/plain, Size: 376 bytes --]
Hi,
This patch is needed in order to compile kernel modules that uses some
of the DCR functions. For example, compiling powerpc emac driver as
module it is needed.
Arnd, Dennis Spathis pinged me about this today and I thought it was a
closed issue but still open. If you find it okay please upstream it or
let me know if any modifications needed. Thanks.
--
Bye,
Murali
[-- Attachment #2: export-dcr-symbols.diff --]
[-- Type: text/x-patch, Size: 1384 bytes --]
Subject: Export few DCR symbols for kernel modules
In order to compile drivers as modules that uses some of the
DCR functions, we need to export the symbols. Example, EMAC
driver and other drivers that are under development uses these
some of the functions.
This patch applies cleanly against 2.6.23-rc1 kernel and ready
for inclusion.
From: Murali Iyer
Signed-off-by: Murali Iyer <mniyer@us•ibm.com>
Index: linux-2.6.22/arch/powerpc/sysdev/dcr.c
===================================================================
--- linux-2.6.22.orig/arch/powerpc/sysdev/dcr.c
+++ linux-2.6.22/arch/powerpc/sysdev/dcr.c
@@ -33,6 +33,7 @@ unsigned int dcr_resource_start(struct d
return dr[index * 2];
}
+EXPORT_SYMBOL_GPL(dcr_resource_start);
unsigned int dcr_resource_len(struct device_node *np, unsigned int index)
{
@@ -44,6 +45,7 @@ unsigned int dcr_resource_len(struct dev
return dr[index * 2 + 1];
}
+EXPORT_SYMBOL_GPL(dcr_resource_len);
#ifndef CONFIG_PPC_DCR_NATIVE
@@ -122,6 +124,7 @@ dcr_host_t dcr_map(struct device_node *d
ret.token -= dcr_n * ret.stride;
return ret;
}
+EXPORT_SYMBOL_GPL(dcr_map);
void dcr_unmap(dcr_host_t host, unsigned int dcr_n, unsigned int dcr_c)
{
@@ -133,5 +136,6 @@ void dcr_unmap(dcr_host_t host, unsigned
iounmap(h.token);
h.token = NULL;
}
+EXPORT_SYMBOL_GPL(dcr_unmap);
#endif /* !defined(CONFIG_PPC_DCR_NATIVE) */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Cbe-oss-dev] Export DCR symbols - resubmitting
2007-08-08 21:46 Export DCR symbols - resubmitting Murali Iyer
@ 2007-08-08 21:58 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2007-08-08 21:58 UTC (permalink / raw)
To: cbe-oss-dev; +Cc: Linuxppc-dev, paulus, Murali Iyer
On Wednesday 08 August 2007, Murali Iyer wrote:
> This patch is needed in order to compile kernel modules that uses some
> of the DCR functions. For example, compiling powerpc emac driver as
> module it is needed.
Ok, thanks!
> Arnd, Dennis Spathis pinged me about this today and I thought it was a
> closed issue but still open. If you find it okay please upstream it or
> let me know if any modifications needed. Thanks.
Paul, please apply in either for-2.6.24 or as a fix for 2.6.23. The patch
is obviously correct, as the now exported functions were meant to be
used by modules in the first place. No code in the kernel currently
uses it, so it's not urgent.
> Signed-off-by: Murali Iyer <mniyer@us•ibm.com>
Acked-by: Arnd Bergmann <arnd.bergmann@de•ibm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-08 21:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-08 21:46 Export DCR symbols - resubmitting Murali Iyer
2007-08-08 21:58 ` [Cbe-oss-dev] " Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox