From: Andrew Morton <akpm@linux-foundation•org>
To: Mariusz Kozlowski <m.kozlowski@tuxland•pl>
Cc: kgdb-bugreport@lists•sourceforge.net, amitkale@linsyssoft•com,
linux-kernel@vger•kernel.org, linuxppc-dev@ozlabs•org,
Paul Mackerras <paulus@samba•org>,
jason.wessel@windriver•com
Subject: Re: 2.6.23-rc3-mm1: kgdb build failure on powerpc
Date: Wed, 22 Aug 2007 12:47:43 -0700 [thread overview]
Message-ID: <20070822124743.fc316963.akpm@linux-foundation.org> (raw)
In-Reply-To: <200708222104.29432.m.kozlowski@tuxland.pl>
On Wed, 22 Aug 2007 21:04:28 +0200
Mariusz Kozlowski <m.kozlowski@tuxland•pl> wrote:
> Hello,
>
> Got that on imac g3.
>
> CC kernel/kgdb.o
> kernel/kgdb.c: In function 'kgdb_handle_exception':
> kernel/kgdb.c:940: error: invalid lvalue in unary '&'
> kernel/kgdb.c:940: warning: type defaults to 'int' in declaration of '_o_'
> kernel/kgdb.c:940: error: invalid lvalue in unary '&'
> kernel/kgdb.c:940: warning: type defaults to 'int' in declaration of '_n_'
> kernel/kgdb.c:940: error: invalid lvalue in unary '&'
> kernel/kgdb.c:940: error: invalid lvalue in unary '&'
> kernel/kgdb.c:940: error: invalid lvalue in unary '&'
> kernel/kgdb.c:940: warning: type defaults to 'int' in declaration of 'type name'
> make[1]: *** [kernel/kgdb.o] Blad 1
> make: *** [kernel] Blad 2
>
I'm not surprised.
while (cmpxchg(&atomic_read(&debugger_active), 0, (procid + 1)) != 0) {
a) cmpxchg isn't available on all architectures
b) we can't just go and take the address of atomic_read()'s return value!
c) that's pretty ugly-looking stuff anyway.
next prev parent reply other threads:[~2007-08-22 19:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070822020648.5ea3a612.akpm@linux-foundation.org>
2007-08-22 19:04 ` 2.6.23-rc3-mm1: kgdb build failure on powerpc Mariusz Kozlowski
2007-08-22 19:47 ` Andrew Morton [this message]
2007-08-22 22:44 ` [Kgdb-bugreport] " Jason Wessel
2007-08-22 23:53 ` Andrew Morton
2007-08-23 3:25 ` Jason Wessel
2007-08-29 23:43 ` Pete/Piet Delaney
2007-08-30 0:05 ` Pete/Piet Delaney
2007-08-30 1:19 ` Pete/Piet Delaney
2007-08-30 1:38 ` Randy Dunlap
2007-08-30 2:07 ` Jason Wessel
2007-08-30 2:13 ` Jason Wessel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070822124743.fc316963.akpm@linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=amitkale@linsyssoft$(echo .)com \
--cc=jason.wessel@windriver$(echo .)com \
--cc=kgdb-bugreport@lists$(echo .)sourceforge.net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=m.kozlowski@tuxland$(echo .)pl \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox