From: Pete/Piet Delaney <pete@bluelane•com>
To: Jason Wessel <jason.wessel@windriver•com>
Cc: kgdb-bugreport@lists•sourceforge.net, amitkale@linsyssoft•com,
linux-kernel@vger•kernel.org, linuxppc-dev@ozlabs•org,
Mariusz Kozlowski <m.kozlowski@tuxland•pl>,
Paul Mackerras <paulus@samba•org>,
Andrew Morton <akpm@linux-foundation•org>
Subject: Re: [Kgdb-bugreport] 2.6.23-rc3-mm1: kgdb build failure on powerpc
Date: Wed, 29 Aug 2007 16:43:59 -0700 [thread overview]
Message-ID: <46D604BF.7090905@bluelane.com> (raw)
In-Reply-To: <46CCFE2C.4050306@windriver.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Jason Wessel wrote:
> Andrew Morton wrote:
>> On Wed, 22 Aug 2007 17:44:12 -0500
>> Jason Wessel <jason.wessel@windriver•com> wrote:
>>
>>
>>> + while (!atomic_read(&debugger_active));
>>>
>>
>> eek. We're in the process of hunting down and eliminating exactly this
>> construct. There have been cases where the compiler cached the
>> atomic_read() result in a register, turning the above into an infinite
>> loop.
>>
>> Plus we should never add power-burners like that into the kernel
>> anyway. That loop should have a cpu_relax() in it. Which will also
>> fix the
>> compiler problem described above.
>>
>>
> Agreed, and fixed with a cpu_relax.
>
>> Thirdly, please always add a newline when coding statements like that:
>>
>> while (expr())
>> ;
>>
>
> The other instances I found of the same problem in the kgdb core are
> fixed too.
>
> I merged all the changes into the for_mm branch in the kgdb git tree.
Where is the kgdb git tree?
- -piet
>
> Thanks,
> Jason.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFG1gS/JICwm/rv3hoRAhfRAJ42F3QlzGwG4aQbs9hHVMI4kJ9SWQCfXrku
UGo97ByKsB9yhyIu5c+2Jh0=
=welB
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2007-08-29 23:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070822020648.5ea3a612.akpm@linux-foundation.org>
2007-08-22 19:04 ` 2.6.23-rc3-mm1: kgdb build failure on powerpc Mariusz Kozlowski
2007-08-22 19:47 ` Andrew Morton
2007-08-22 22:44 ` [Kgdb-bugreport] " Jason Wessel
2007-08-22 23:53 ` Andrew Morton
2007-08-23 3:25 ` Jason Wessel
2007-08-29 23:43 ` Pete/Piet Delaney [this message]
2007-08-30 0:05 ` Pete/Piet Delaney
2007-08-30 1:19 ` Pete/Piet Delaney
2007-08-30 1:38 ` Randy Dunlap
2007-08-30 2:07 ` Jason Wessel
2007-08-30 2:13 ` Jason Wessel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D604BF.7090905@bluelane.com \
--to=pete@bluelane$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=amitkale@linsyssoft$(echo .)com \
--cc=jason.wessel@windriver$(echo .)com \
--cc=kgdb-bugreport@lists$(echo .)sourceforge.net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=m.kozlowski@tuxland$(echo .)pl \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox