From: "Gerhard Pircher" <gerhard_pircher@gmx•net>
To: David Gibson <david@gibson•dropbear.id.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [RFC] AmigaOne device tree source v2
Date: Mon, 03 Sep 2007 16:58:14 +0200 [thread overview]
Message-ID: <20070903145814.101070@gmx.net> (raw)
In-Reply-To: <20070903013431.GG31499@localhost.localdomain>
Hi,
-------- Original-Nachricht --------
> Datum: Mon, 3 Sep 2007 11:34:31 +1000
> Von: David Gibson <david@gibson•dropbear.id.au>
> An: Gerhard Pircher <gerhard_pircher@gmx•net>
> CC: linuxppc-dev@ozlabs•org
> Betreff: Re: [RFC] AmigaOne device tree source v2
> Interrupt routing information is really necessary. If it differs
> between the models then either you will need different device tree
> source for each of them, or you will need to fill in the correct
> interrupt routing information from the bootwrapper, whichever approach
> is easier.
Okay, I could probe the southbridge's PCI interrupt registers to fill in
some of the interrupt routing information from the bootwrapper.
> I believe that's handled by the bridge's compatible and reg
> properties. The platform or bridge code will have to know that this
> type of bridge (as encoded in compatible) uses indirect addressing,
> and which resource (from the reg property) has the indirect access
> registers.
Well, then I'll copy and paste from the CHRP/Pegasos PCI setup code,
which should exactly do that. :-)
> I don't know enough about PCI to answer most of the above questions,
> but I spotted a bunch of problems with the device tree anyway...
> > pci@80000000 {
> > device_type = "pci";
> > bus-frequency = <01fca055>; // 33.3MHz
> > bus-range = <0 1>;
> > reg = <80000000 7f000000>; //
> >Whole PCI space.
>
> 'reg' and 'ranges' should not typically overlap. 'reg' should only
> encode control registers for the bridge, not the whole PCI space (not
> that I'm even entirely sure what you mean by that).
Hmm, strange. I'm sure I found this in another device tree. I define
"whole PCI space" as PCI (prefetchable) memory and PCI I/O space.
> > host@0 {
>
> The unit address (after the @) should be derived from the first range
> listed in the 'reg' property. It's a bus address, not a slot number.
AFAIK it's the device number, which is 0 for this host/PCI bridge.
> > vendor-id = 0x000010cc;
>
> Um.. evidentally you have never even tried compiling this device tree,
> since this is invalid syntax. That would need to be:
> vendor-id = <000010cc>;
> and likewise all the others below.
Uh, yeah! I thought I fixed all these typos. You're right, I didn't try
to compile the device tree yet.
> > #interrupt-cells = <2>;
> > #address-cells = <2>;
> > #size-cells = <1>;
> >
> > dma-controller {
>
> All these devices should have unit addresses.
Okay, that would be dma-controller@0, interrupt-controller@20 and so.
Will be fixed!
> > ide@7,1 {
>
> This will need a compatible property, at least.
I hoped the class-code property is enough for a PCI device, as it
clearly identifies this device as a PCI IDE conroller with primary and
secondary master functionality.
Thanks!
regards,
Gerhard
--
Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen!
Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer
next prev parent reply other threads:[~2007-09-03 14:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-31 17:50 [RFC] AmigaOne device tree source v2 Gerhard Pircher
2007-09-03 1:34 ` David Gibson
2007-09-03 8:41 ` Benjamin Herrenschmidt
2007-09-03 10:02 ` Segher Boessenkool
2007-09-03 10:12 ` David Gibson
2007-09-03 16:11 ` Gerhard Pircher
2007-09-03 22:52 ` Segher Boessenkool
2007-09-04 0:27 ` David Gibson
2007-09-06 13:31 ` Segher Boessenkool
2007-09-04 12:20 ` Gerhard Pircher
2007-09-06 13:41 ` Segher Boessenkool
2007-09-03 14:58 ` Gerhard Pircher [this message]
2007-09-03 22:32 ` Segher Boessenkool
2007-09-04 11:49 ` Gerhard Pircher
2007-09-05 2:48 ` David Gibson
2007-09-05 11:54 ` Gerhard Pircher
2007-09-06 14:00 ` Segher Boessenkool
2007-09-06 14:09 ` Sven Luther
2007-09-06 14:42 ` Segher Boessenkool
2007-09-06 13:56 ` Segher Boessenkool
2007-09-06 14:15 ` PCI I/O space -- reg or ranges? Scott Wood
2007-09-06 20:51 ` Gerhard Pircher
2007-09-06 21:01 ` Segher Boessenkool
2007-09-07 0:20 ` [RFC] AmigaOne device tree source v2 David Gibson
2007-09-06 13:36 ` Segher Boessenkool
2007-09-06 21:09 ` Gerhard Pircher
2007-09-07 0:21 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070903145814.101070@gmx.net \
--to=gerhard_pircher@gmx$(echo .)net \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox