public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom•net>
To: Linus Torvalds <torvalds@linux-foundation•org>
Cc: Greg KH <greg@kroah•com>, Greg KH <gregkh@suse•de>,
	linux-kernel@vger•kernel.org,
	Chris Wedgwood <reviews@ml•cw.f00f.org>,
	linuxppc-dev@ozlabs•org, paulus@samba•org, tgall.foo@gmail•com,
	Thomas Gleixner <tglx@linutronix•de>,
	stable@kernel•org
Subject: [PATCH] powerpc: don't enable cpu hotplug on mpic-based pseries
Date: Tue, 9 Oct 2007 19:08:15 -0500	[thread overview]
Message-ID: <20071010000815.GB7875@lixom.net> (raw)
In-Reply-To: <alpine.LFD.0.999.0710091625520.3838@woody.linux-foundation.org>

Don't allow cpu hotplug on systems lacking XICS interrupt controller,
since current platform code is hardcoded for it.


Signed-off-by: Olof Johansson <olof@lixom•net>


diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c
index 9711eb0..e29b890 100644
--- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
+++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
@@ -252,6 +252,19 @@ static struct notifier_block pseries_smp_nb = {
 
 static int __init pseries_cpu_hotplug_init(void)
 {
+	struct device_node *np;
+	const char *typep;
+
+	for (np = NULL; (np = of_find_node_by_name(np,
+						   "interrupt-controller"));) {
+		typep = of_get_property(np, "compatible", NULL);
+		if (strstr(typep, "open-pic")) {
+			printk(KERN_INFO "CPU Hotplug not supported on "
+				"systems using MPIC\n");
+			return 0;
+		}
+	}
+
 	rtas_stop_self_args.token = rtas_token("stop-self");
 	qcss_tok = rtas_token("query-cpu-stopped-state");
 

  parent reply	other threads:[~2007-10-10  0:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071008180406.052382073@mini.kroah.org>
     [not found] ` <20071008180633.GJ7627@kroah.com>
     [not found]   ` <20071009151702.GA19209@lixom.net>
     [not found]     ` <20071009222003.GA21228@kroah.com>
     [not found]       ` <alpine.LFD.0.9999.0710100120340.7766@localhost.localdomain>
     [not found]         ` <alpine.LFD.0.999.0710091625520.3838@woody.linux-foundation.org>
2007-10-10  0:03           ` [stable] [patch 09/12] Fix SMP poweroff hangs Olof Johansson
2007-10-10  0:08           ` Olof Johansson [this message]
2007-10-10  0:18             ` [PATCH] powerpc: don't enable cpu hotplug on mpic-based pseries Stephen Rothwell
2007-10-10  0:38               ` [PATCH v2] " Olof Johansson
2007-10-10 10:08                 ` Milton Miller
2007-10-10 16:43                   ` Olof Johansson
2007-10-11 15:25                     ` Milton Miller
2007-10-11  5:52                 ` Paul Mackerras
2007-10-11  5:59                   ` Olof Johansson
2007-10-11 21:42                   ` Milton Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071010000815.GB7875@lixom.net \
    --to=olof@lixom$(echo .)net \
    --cc=greg@kroah$(echo .)com \
    --cc=gregkh@suse$(echo .)de \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=paulus@samba$(echo .)org \
    --cc=reviews@ml$(echo .)cw.f00f.org \
    --cc=stable@kernel$(echo .)org \
    --cc=tgall.foo@gmail$(echo .)com \
    --cc=tglx@linutronix$(echo .)de \
    --cc=torvalds@linux-foundation$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox