From: Milton Miller <miltonm@bga•com>
To: Olof Johansson <olof@lixom•net>
Cc: ppcdev <linuxppc-dev@ozlabs•org>, Paul Mackerras <paulus@samba•org>
Subject: Re: [PATCH v2] powerpc: don't enable cpu hotplug on mpic-based pseries
Date: Thu, 11 Oct 2007 10:25:56 -0500 [thread overview]
Message-ID: <c3f800aec25dff34b59b8b496eee3f3b@bga.com> (raw)
In-Reply-To: <20071010164336.GA21507@lixom.net>
On Oct 10, 2007, at 11:43 AM, Olof Johansson wrote:
> On Wed, Oct 10, 2007 at 05:08:44AM -0500, Milton Miller wrote:
>> Olof's patch searched the device-tree again, looking for an mpic.
>> This
>> code instead checks that we found an xics the first time by checking
>> the
>> init function.
>
> I'm glad you find the kernel so perfect that your best use of time is
> to tweak the code added in a non-critical path (performance-wise) with
> a new way of checking for hardware features (no other code in the
> kernel
> checks ppc_md function pointers for that purpose).
I never argued performance, I posted because !mpic != !!xics. The
tweak of not searching again was about avoiding code duplication. I
considered moving the call from an init function to an explicit call
when we find it like the smp and kexec hooks are handled. It would
reorder the notifier registration (from arch_initcall to setup_arch)
which would require additional testing.
> Pseries can only have mpic or xics, so it's not like it matters if we
> check for mpic or !xics, either.
Actually, in my work with simulators, sometimes I use neither, so the
check is not equivalent. We recently changed the call to
ppc_md.init_IRQ to allow this.
> But hey, any color bike shed will do, and I don't care which one Paul
> chooses to merge. I will not waste more time debating this simple patch
> though. :)
>
> -Olof
milton
next prev parent reply other threads:[~2007-10-11 15:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071008180406.052382073@mini.kroah.org>
[not found] ` <20071008180633.GJ7627@kroah.com>
[not found] ` <20071009151702.GA19209@lixom.net>
[not found] ` <20071009222003.GA21228@kroah.com>
[not found] ` <alpine.LFD.0.9999.0710100120340.7766@localhost.localdomain>
[not found] ` <alpine.LFD.0.999.0710091625520.3838@woody.linux-foundation.org>
2007-10-10 0:03 ` [stable] [patch 09/12] Fix SMP poweroff hangs Olof Johansson
2007-10-10 0:08 ` [PATCH] powerpc: don't enable cpu hotplug on mpic-based pseries Olof Johansson
2007-10-10 0:18 ` Stephen Rothwell
2007-10-10 0:38 ` [PATCH v2] " Olof Johansson
2007-10-10 10:08 ` Milton Miller
2007-10-10 16:43 ` Olof Johansson
2007-10-11 15:25 ` Milton Miller [this message]
2007-10-11 5:52 ` Paul Mackerras
2007-10-11 5:59 ` Olof Johansson
2007-10-11 21:42 ` Milton Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3f800aec25dff34b59b8b496eee3f3b@bga.com \
--to=miltonm@bga$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=olof@lixom$(echo .)net \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox