From: Joseph Fannin <jfannin@gmail•com>
To: linuxppc-dev@ozlabs•org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail•com>
Subject: current -git adbhid.c build error
Date: Tue, 16 Oct 2007 14:16:44 -0400 [thread overview]
Message-ID: <20071016181644.GA9337@nineveh.local> (raw)
Hello.
Commit b981d8b3f5e008ff10d993be633ad00564fc22cd in Linus's git tree
did this:
@@ -374,9 +373,9 @@ adbhid_input_keycode(int id, int scancode, int repeat)
#endif /* CONFIG_PPC_PMAC */
}
- if (adbhid[id]->keycode[keycode]) {
- input_report_key(adbhid[id]->input,
- adbhid[id]->keycode[keycode],
adbhid[id]->!up_flag);
+ key = adbhid[id]->keycode[keycode];
+ if (key) {
+ input_report_key(adbhid[id]->input, key, !up_flag);
input_sync(adbhid[id]->input);
} else
printk(KERN_INFO "Unhandled ADB key (scancode %#02x)
%s.\n", keycode,
... but did not define "key":
drivers/macintosh/adbhid.c: In function ‘adbhid_input_keycode’:
drivers/macintosh/adbhid.c:376: error: ‘key’ undeclared (first use in this function)
Gitweb says something about a merge conflict in this file, so maybe
Linus did this, and not Dmitry?
I'll leave it up to someone else to decide how best this variable
should be defined.
--
Joseph Fannin
jfannin@gmail•com
next reply other threads:[~2007-10-16 18:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 18:16 Joseph Fannin [this message]
2007-10-17 4:19 ` current -git adbhid.c build error Paul Mackerras
2007-10-17 4:31 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071016181644.GA9337@nineveh.local \
--to=jfannin@gmail$(echo .)com \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox