From: "Dale Farnsworth" <dale@farnsworth•org>
To: pbadari@us•ibm.com
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 1/3] Add remove_memory() for ppc64
Date: 31 Oct 2007 14:47:54 -0700 [thread overview]
Message-ID: <20071031214754.32735.qmail@farnsworth.org> (raw)
In-Reply-To: <1193867133.17412.49.camel@dyn9047017100.beaverton.ibm.com>
Badari Pulavarty wrote:
> On Thu, 2007-11-01 at 01:26 -0500, Kumar Gala wrote:
> > On Oct 31, 2007, at 11:49 AM, Badari Pulavarty wrote:
> >
> > > Supply arch specific remove_memory() for PPC64. There is nothing
> > > ppc specific code here and its exactly same as ia64 version.
> > > For now, lets keep it arch specific - so each arch can add
> > > its own special things if needed.
> > >
> > > Signed-off-by: Badari Pulavarty <pbadari@us•ibm.com>
> > > ---
> >
> > What's ppc64 specific about these patches?
>
> Like I mentioned, nothing. When KAME did the hotplug memory
> remove, he kept this remove_memory() arch-specific - so
> each arch can provide its own, if it needs to something
> special. So far, there is no need for arch-specific
> remove_memory(). If other archs (x86-64 and others)
> agree we can merge this into arch neutral code.
>
> I have to provide this for ppc64 to plug into general
> frame work.
You've added it to arch/powerpc for both PPC32 and PPC64, so your
commit description is misleading.
-Dale
prev parent reply other threads:[~2007-10-31 21:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 16:49 [PATCH 1/3] Add remove_memory() for ppc64 Badari Pulavarty
2007-10-31 20:45 ` Dave Hansen
2007-10-31 22:11 ` Badari Pulavarty
2007-10-31 21:55 ` Dave Hansen
2007-11-01 0:46 ` KAMEZAWA Hiroyuki
2007-10-31 22:13 ` Badari Pulavarty
2007-11-01 6:26 ` Kumar Gala
2007-10-31 21:45 ` Badari Pulavarty
2007-10-31 21:47 ` Dale Farnsworth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071031214754.32735.qmail@farnsworth.org \
--to=dale@farnsworth$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=pbadari@us$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox