From: Olof Johansson <olof@lixom•net>
To: Anton Vorontsov <cbou@mail•ru>
Cc: linux-ide@vger•kernel.org, Paul Mundt <lethal@linux-sh•org>,
Jeff Garzik <jeff@garzik•org>, Arnd Bergmann <arnd@arndb•de>,
linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 0/3] OF-platform PATA driver
Date: Sun, 2 Dec 2007 09:45:39 -0600 [thread overview]
Message-ID: <20071202154539.GA12415@lixom.net> (raw)
In-Reply-To: <20071202114617.GA2923@zarina>
On Sun, Dec 02, 2007 at 02:46:17PM +0300, Anton Vorontsov wrote:
> On Sat, Dec 01, 2007 at 09:57:55PM -0600, Olof Johansson wrote:
> > On Sun, Dec 02, 2007 at 02:58:10AM +0300, Anton Vorontsov wrote:
> > > On Sat, Dec 01, 2007 at 05:54:49PM -0500, Jeff Garzik wrote:
> > > while (1) {
> > > send_patches();
> > >
> > > if (ack_collected(PaulM) && ack_collected(PowerPC_people))
> > > break;
> > >
> > > sleep(wait_for_comments_timeout); <-- currently here.
> >
> > I still haven't seen you address the compatible comments (that
> > pata-platform is suboptimal). Or did I miss some respin of the patches?
>
> I didn't resend these patches yet. You started the thread, but you hid
> away from the discussion (you had been Cc'ed to every mail).
>
> 1. Arnd suggested {p,s}ata-pio-{1,2,3,..} or ata-{1,2,3,..} compatible
> scheme;
> 2. Sergei verbosely explained that that there is no reason to
> complicate compatible property. He suggested ata-generic, or
> ata-simple;
>
> Mainly I was awaiting for your further comments. By now I tend to
> follow Sergei's comments and rename compatible stuff to ata-generic.
> Are you fine with it?
Ah, sorry about that. The discussion got a bit noisy so I tuned it out.
Yes, I agree with Sergei: I don't think the pio/ata mode belongs there,
"ata-generic" (or "generic-ata") sounds good to me. If firmwares want to
specify pata/sata stuff as more specific compatible fields, then they are
free to, but the driver shouldn't depend on it as long as "ata-generic"
is in the list.
ATA/PIO modes could be communicated with separate properties as well,
but I don't see a need for it right now. Tuning PIO modes normally
involves changing bus parameters/cycle times, etc, and that' hardly
generic enough to be handled by this driver in the first place.
I will need to add a compatible field to it myself (our firmware uses
"electra-ide") + some minor changes, but I will do that on top of this
patch once it goes in since it involves removing the old code from
arch/powerpc/platforms/pasemi.
-Olof
next prev parent reply other threads:[~2007-12-02 15:41 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 15:37 [PATCH 0/3] OF-platform PATA driver Anton Vorontsov
2007-11-27 15:39 ` [PATCH 1/3] [libata] pata_platform: make probe and remove functions device type neutral Anton Vorontsov
2007-11-27 22:31 ` Arnd Bergmann
2007-11-27 15:39 ` [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver Anton Vorontsov
2007-11-27 21:22 ` Olof Johansson
2007-11-27 21:32 ` Arnd Bergmann
2007-11-28 15:49 ` Anton Vorontsov
2007-11-28 16:11 ` Sergei Shtylyov
2007-11-29 0:54 ` Anton Vorontsov
2007-11-30 10:17 ` Sergei Shtylyov
2007-11-30 10:58 ` Anton Vorontsov
2007-11-30 11:05 ` Sergei Shtylyov
2007-11-30 11:45 ` Anton Vorontsov
2007-11-30 11:43 ` Sergei Shtylyov
2007-11-30 12:09 ` Anton Vorontsov
2007-11-28 16:29 ` Sergei Shtylyov
2007-11-28 0:41 ` Stephen Rothwell
2007-12-02 3:59 ` Olof Johansson
2007-11-27 15:39 ` [PATCH 3/3] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes Anton Vorontsov
2007-11-27 15:49 ` Sergei Shtylyov
2007-11-27 16:41 ` Anton Vorontsov
2007-11-27 16:46 ` Sergei Shtylyov
2007-11-27 17:27 ` Anton Vorontsov
2007-11-27 17:25 ` Sergei Shtylyov
2007-11-27 17:34 ` Anton Vorontsov
2007-11-27 17:34 ` Sergei Shtylyov
2007-11-27 17:48 ` Anton Vorontsov
2007-11-27 18:07 ` Sergei Shtylyov
2007-11-27 19:50 ` Anton Vorontsov
2007-11-27 21:18 ` Kumar Gala
2007-11-28 9:51 ` [PATCH 0/3] OF-platform PATA driver Paul Mundt
2007-11-28 13:24 ` Anton Vorontsov
2007-12-01 22:54 ` Jeff Garzik
2007-12-01 23:58 ` Anton Vorontsov
2007-12-02 3:57 ` Olof Johansson
2007-12-02 11:46 ` Anton Vorontsov
2007-12-02 15:45 ` Olof Johansson [this message]
2007-12-02 23:40 ` Arnd Bergmann
2007-12-02 23:58 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071202154539.GA12415@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=arnd@arndb$(echo .)de \
--cc=cbou@mail$(echo .)ru \
--cc=jeff@garzik$(echo .)org \
--cc=lethal@linux-sh$(echo .)org \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox