From: Sergei Shtylyov <sshtylyov@ru•mvista.com>
To: avorontsov@ru•mvista.com
Cc: Olof Johansson <olof@lixom•net>,
cbou@mail•ru, linux-ide@vger•kernel.org,
Arnd Bergmann <arnd@arndb•de>,
linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver
Date: Fri, 30 Nov 2007 14:05:01 +0300 [thread overview]
Message-ID: <474FEE5D.2030905@ru.mvista.com> (raw)
In-Reply-To: <20071130105849.GA10840@localhost.localdomain>
Anton Vorontsov wrote:
>>>Remaining question: any preferred name for that property? pio-mode okay?
>>>It's assuming that PIO6 capable bus supports PIO0 as well, thus no mask.
>> I've already suggested "generic". A name "simple" also comes to my mind.
> You've misread my question. I didn't ask about driver name, but pio-mode
> property.
I'm OK with "pio-mode" then. Just don't think it makes much sense in the
context of this driver which has no provision for the programming the mode
timings (and if there were some provision, the *generic* platform driver
couldn't handle it anyway).
> As for the driver name, it doesn't matter at all, as I've said already:
> it's Linux specific anyway, and another compatible properties could be
> added at any time, to a device tree and/or to the OF driver itself (if
> some real OpenFirmware will pass some meaningful compatible property
> that we'll have to match in that driver).
> "generic" name is also bad one, it's confusing wrt ata_generic.c
> driver (PCI).
The "compatible" property doesn't have to contain the driver name, so
there should be no confusion with the driver names. It's just different name
spaces. :-)
> "simple" name doesn't tell anything at all. So, I'd rather stick with -platform name.
Well, those two should be "generic-ata" and "simple-ata" of course. And it
*does* tell that the driver just provides taskfile control, without the
transfer timing control and other fancy stuff...
> Thanks,
MBR, Sergei
next prev parent reply other threads:[~2007-11-30 11:04 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 15:37 [PATCH 0/3] OF-platform PATA driver Anton Vorontsov
2007-11-27 15:39 ` [PATCH 1/3] [libata] pata_platform: make probe and remove functions device type neutral Anton Vorontsov
2007-11-27 22:31 ` Arnd Bergmann
2007-11-27 15:39 ` [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver Anton Vorontsov
2007-11-27 21:22 ` Olof Johansson
2007-11-27 21:32 ` Arnd Bergmann
2007-11-28 15:49 ` Anton Vorontsov
2007-11-28 16:11 ` Sergei Shtylyov
2007-11-29 0:54 ` Anton Vorontsov
2007-11-30 10:17 ` Sergei Shtylyov
2007-11-30 10:58 ` Anton Vorontsov
2007-11-30 11:05 ` Sergei Shtylyov [this message]
2007-11-30 11:45 ` Anton Vorontsov
2007-11-30 11:43 ` Sergei Shtylyov
2007-11-30 12:09 ` Anton Vorontsov
2007-11-28 16:29 ` Sergei Shtylyov
2007-11-28 0:41 ` Stephen Rothwell
2007-12-02 3:59 ` Olof Johansson
2007-11-27 15:39 ` [PATCH 3/3] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes Anton Vorontsov
2007-11-27 15:49 ` Sergei Shtylyov
2007-11-27 16:41 ` Anton Vorontsov
2007-11-27 16:46 ` Sergei Shtylyov
2007-11-27 17:27 ` Anton Vorontsov
2007-11-27 17:25 ` Sergei Shtylyov
2007-11-27 17:34 ` Anton Vorontsov
2007-11-27 17:34 ` Sergei Shtylyov
2007-11-27 17:48 ` Anton Vorontsov
2007-11-27 18:07 ` Sergei Shtylyov
2007-11-27 19:50 ` Anton Vorontsov
2007-11-27 21:18 ` Kumar Gala
2007-11-28 9:51 ` [PATCH 0/3] OF-platform PATA driver Paul Mundt
2007-11-28 13:24 ` Anton Vorontsov
2007-12-01 22:54 ` Jeff Garzik
2007-12-01 23:58 ` Anton Vorontsov
2007-12-02 3:57 ` Olof Johansson
2007-12-02 11:46 ` Anton Vorontsov
2007-12-02 15:45 ` Olof Johansson
2007-12-02 23:40 ` Arnd Bergmann
2007-12-02 23:58 ` Olof Johansson
-- strict thread matches above, loose matches on Subject: below --
2008-01-09 19:08 [PATCH v4 " Anton Vorontsov
2008-01-09 19:10 ` [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver Anton Vorontsov
2008-01-09 23:40 ` Stephen Rothwell
2008-01-10 0:36 ` Olof Johansson
2008-01-10 2:17 ` Stephen Rothwell
2007-12-14 18:21 [PATCH v3 0/3] OF-platform PATA driver Anton Vorontsov
2007-12-14 18:24 ` [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver Anton Vorontsov
2007-12-15 14:09 ` Stephen Rothwell
2007-12-15 15:19 ` Anton Vorontsov
2007-11-23 17:52 [RFC][PATCH 0/3] OF-platform PATA driver Anton Vorontsov
2007-11-23 17:53 ` [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474FEE5D.2030905@ru.mvista.com \
--to=sshtylyov@ru$(echo .)mvista.com \
--cc=arnd@arndb$(echo .)de \
--cc=avorontsov@ru$(echo .)mvista.com \
--cc=cbou@mail$(echo .)ru \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=olof@lixom$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox