From: Arnd Bergmann <arnd@arndb•de>
To: benh@kernel•crashing.org
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom•com>,
linuxppc-dev@ozlabs•org, olof@lixom•net
Subject: Re: [PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code
Date: Tue, 4 Dec 2007 22:52:36 +0100 [thread overview]
Message-ID: <200712042252.37308.arnd@arndb.de> (raw)
In-Reply-To: <1196800273.13230.333.camel@pasglop>
On Tuesday 04 December 2007, Benjamin Herrenschmidt wrote:
> On Tue, 2007-12-04 at 20:35 +0100, Arnd Bergmann wrote:
> >
> > 1. If another platform gets added that uses the same firmware feature,
> > it
> > will automatically do the right thing.
>
> Yes but is it something that we want to happen ? That is, do we want
> code somewhere in a platform/foo dir to run when using platform/bar
> because they happen to share a feature ?
It should be decided case-by-case of course. My assumption was that
in those places where we currently check the firmware feature, that
is actually the right thing to do.
For the lv1 specific device drivers (vuart, sound, graphics, ...),
my feeling is that they should really check for lv1, not for ps3,
because the check for lv1 is only needed in order to make sure
that you can run the hcall that probes for the actual device.
For some of the iseries checks, it would be more logical to test
the platform instead of the firmware feature IMHO, but I don't see a
significant reason to change that.
Arnd <><
next prev parent reply other threads:[~2007-12-04 21:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 6:10 [PATCH v2 1/2] [POWERPC] Add machine initcall macros Grant Likely
2007-12-02 6:10 ` [PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code Grant Likely
2007-12-02 6:17 ` Grant Likely
2007-12-02 19:15 ` Olof Johansson
2007-12-04 12:23 ` Geert Uytterhoeven
2007-12-04 13:36 ` Grant Likely
2007-12-04 13:43 ` Geert Uytterhoeven
2007-12-04 20:59 ` Geoff Levand
2007-12-04 14:21 ` Grant Likely
2007-12-04 19:35 ` Arnd Bergmann
2007-12-04 20:31 ` Benjamin Herrenschmidt
2007-12-04 21:52 ` Arnd Bergmann [this message]
2007-12-04 22:05 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712042252.37308.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=Geert.Uytterhoeven@sonycom$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=olof@lixom$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox