From: Geoff Levand <geoffrey.levand@am•sony.com>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom•com>
Cc: Linux/PPC Development <linuxppc-dev@ozlabs•org>, olof@lixom•net
Subject: Re: [PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code
Date: Tue, 04 Dec 2007 12:59:55 -0800 [thread overview]
Message-ID: <4755BFCB.9010502@am.sony.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0712041442530.12181@pademelon.sonytel.be>
Geert Uytterhoeven wrote:
> On Tue, 4 Dec 2007, Grant Likely wrote:
>> On 12/4/07, Geert Uytterhoeven <Geert.Uytterhoeven@sonycom•com> wrote:
>> > On Sat, 1 Dec 2007, Grant Likely wrote:
>> > > From: Grant Likely <grant.likely@secretlab•ca>
>> > >
>> > > This patch makes the platform code use the new machine-specific initcall
>> > > hooks. This has the advantage of not needing to explicitly test
>> > > machine_is() at the top of every initcall function.
>> >
>> > You seem to have missed the PS3 *_initcall()s.
>> > Probably because they test for firmware_has_feature(FW_FEATURE_PS3_LV1) instead
>> > of machine_is(ps3).
>>
>> That's exactly why; I didn't know if 'machine_is(ps3)' was a suitable
>> substitute so I left it alone.
>
> I think it's OK. But...
>
> Geoff: is there any specific reason why you used
> firmware_has_feature(FW_FEATURE_PS3_LV1)?
As Arnd pointed out, the code in the firmware_has_feature() conditional
will be removed by the optimizer when the kernel is built without support
for that feature. This then gives a multi-platform binary that has only
the code for the sub-set of features the user selected.
-Geoff
next prev parent reply other threads:[~2007-12-04 21:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 6:10 [PATCH v2 1/2] [POWERPC] Add machine initcall macros Grant Likely
2007-12-02 6:10 ` [PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code Grant Likely
2007-12-02 6:17 ` Grant Likely
2007-12-02 19:15 ` Olof Johansson
2007-12-04 12:23 ` Geert Uytterhoeven
2007-12-04 13:36 ` Grant Likely
2007-12-04 13:43 ` Geert Uytterhoeven
2007-12-04 20:59 ` Geoff Levand [this message]
2007-12-04 14:21 ` Grant Likely
2007-12-04 19:35 ` Arnd Bergmann
2007-12-04 20:31 ` Benjamin Herrenschmidt
2007-12-04 21:52 ` Arnd Bergmann
2007-12-04 22:05 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4755BFCB.9010502@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=Geert.Uytterhoeven@sonycom$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=olof@lixom$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox