From: Olof Johansson <olof@lixom•net>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: Jean Delvare <khali@linux-fr•org>,
linuxppc-dev@ozlabs•org, i2c@lm-sensors•org
Subject: Re: [i2c] [PATCH 0/4] Series to add device tree naming to i2c
Date: Sun, 9 Dec 2007 15:53:07 -0600 [thread overview]
Message-ID: <20071209215307.GC26651@lixom.net> (raw)
In-Reply-To: <1197236326.6563.22.camel@pasglop>
On Mon, Dec 10, 2007 at 08:38:46AM +1100, Benjamin Herrenschmidt wrote:
>
> > +static struct i2c_device_id rs5c372_id[] = {
> > + {"rtc-rs5c372", rtc_rs5c372a},
> > + {"rs5c372a", rtc_rs5c372a},
> > + {"rs5c372b", rtc_rs5c372b},
> > + {"rv5c386", rtc_rv5c386},
> > + {"rv5c387a", rtc_rv5c387a},
> > + DT_NAME({"ricoh,rs5c372a", rtc_rs5c372a},)
> > + DT_NAME({"ricoh,rs5c372b", rtc_rs5c372b},)
> > + DT_NAME({"ricoh,rv5c386", rtc_rv5c386},)
> > + DT_NAME({"ricoh,rv5c387a", rtc_rv5c387a},)
> > + {},
> >
> > But what's the point in making these names specific to device trees?
> > They are perfectly valid names for the devices that could be used from
> > any platform.
>
> The more I think about it, the more I tend to agree that tagging isn't
> necessary and you are right. We should just match the name against the
> "compatible" property of the OF nodes (which mean we need to support
> multiple matches though since "compatible" is a list of strings).
>
> Now, I have a question about your example: Why do you have both
> "rs5c372a" and "ricoh,rs5c372a" ?
>
> I would argue that we should keep only the later...
I think existing platforms register with the simpler name, so they would
need to be changed. Having both shouldn't do harm though, we tend to
sometimes do the same with of_platform drivers for legacy reasons.
Unless someone adds a ridicously simple match name (by mistake or
whatever), it shouldn't be a problem. And if someone does it to some
dts/firmware, then we'll just need to add device tree fixups to set the
"vendor,product" string instead, yet again similar to how we have to do
sometimes with other drivers/devices.
-Olof
next prev parent reply other threads:[~2007-12-09 21:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 21:20 [PATCH 0/4] Series to add device tree naming to i2c Jon Smirl
2007-12-03 21:20 ` [PATCH 1/4] Implement module aliasing for i2c to translate from device tree names Jon Smirl
2007-12-03 21:20 ` [PATCH 2/4] Modify several rtc drivers to use the alias names list property of i2c Jon Smirl
2007-12-03 21:20 ` [PATCH 3/4] Convert PowerPC MPC i2c to of_platform_driver from platform_driver Jon Smirl
2007-12-03 21:20 ` [PATCH 4/4] Convert pfc8563 i2c driver from old style to new style Jon Smirl
2007-12-03 23:37 ` [PATCH 0/4] Series to add device tree naming to i2c Olof Johansson
2007-12-03 23:51 ` Scott Wood
2007-12-03 23:52 ` Jon Smirl
2007-12-04 0:04 ` Olof Johansson
2007-12-09 20:24 ` [i2c] " Jon Smirl
2007-12-09 20:39 ` Olof Johansson
2007-12-09 20:46 ` Benjamin Herrenschmidt
2007-12-09 20:57 ` Jon Smirl
2007-12-09 21:13 ` Benjamin Herrenschmidt
2007-12-09 21:35 ` Jon Smirl
2007-12-09 21:38 ` Benjamin Herrenschmidt
2007-12-09 21:46 ` Jon Smirl
2007-12-09 21:53 ` Olof Johansson [this message]
2007-12-10 16:42 ` Scott Wood
2007-12-10 18:06 ` Jon Smirl
2007-12-10 18:37 ` Scott Wood
2007-12-10 18:52 ` Jon Smirl
2007-12-10 20:35 ` Benjamin Herrenschmidt
2007-12-10 20:32 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071209215307.GC26651@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=benh@kernel$(echo .)crashing.org \
--cc=i2c@lm-sensors$(echo .)org \
--cc=khali@linux-fr$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox