From: Olof Johansson <olof@lixom•net>
To: Jon Smirl <jonsmirl@gmail•com>
Cc: linuxppc-dev@ozlabs•org, i2c@lm-sensors•org
Subject: Re: [PATCH 0/4] Series to add device tree naming to i2c
Date: Mon, 3 Dec 2007 17:37:52 -0600 [thread overview]
Message-ID: <20071203233752.GA7041@lixom.net> (raw)
In-Reply-To: <20071203212032.23543.3453.stgit@terra.home>
On Mon, Dec 03, 2007 at 04:20:32PM -0500, Jon Smirl wrote:
> The following series implements standard linux module aliasing for i2c modules
> It then converts the mpc i2c driver from being a platform driver to an open
> firmware one. I2C device names are picked up from the device tree. Module
> aliasing is used to translate from device tree names into to linux kernel
> names. Several i2c drivers are updated to use the new aliasing.
May I ask why you want to modify the i2c layer instead of keeping the
OF->i2c driver mapping in PPC code? It seems simpler to keep it in the
PPC-specific code, since otherwise you might end up with confused i2c
driver writers that make up their own OF names without knowing for sure
that's what will be used. No?
I recently posted (and asked Paulus to pull) a patch where I consolidate
the fsl_soc mapping code so I can also use that on pasemi, and modified
the pasemi platform code to setup the board_info from the device tree
accordingly.
Finally, whitespace is broken in several of your patches.
-Olof
next prev parent reply other threads:[~2007-12-03 23:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 21:20 [PATCH 0/4] Series to add device tree naming to i2c Jon Smirl
2007-12-03 21:20 ` [PATCH 1/4] Implement module aliasing for i2c to translate from device tree names Jon Smirl
2007-12-03 21:20 ` [PATCH 2/4] Modify several rtc drivers to use the alias names list property of i2c Jon Smirl
2007-12-03 21:20 ` [PATCH 3/4] Convert PowerPC MPC i2c to of_platform_driver from platform_driver Jon Smirl
2007-12-03 21:20 ` [PATCH 4/4] Convert pfc8563 i2c driver from old style to new style Jon Smirl
2007-12-03 23:37 ` Olof Johansson [this message]
2007-12-03 23:51 ` [PATCH 0/4] Series to add device tree naming to i2c Scott Wood
2007-12-03 23:52 ` Jon Smirl
2007-12-04 0:04 ` Olof Johansson
2007-12-09 20:24 ` [i2c] " Jon Smirl
2007-12-09 20:39 ` Olof Johansson
2007-12-09 20:46 ` Benjamin Herrenschmidt
2007-12-09 20:57 ` Jon Smirl
2007-12-09 21:13 ` Benjamin Herrenschmidt
2007-12-09 21:35 ` Jon Smirl
2007-12-09 21:38 ` Benjamin Herrenschmidt
2007-12-09 21:46 ` Jon Smirl
2007-12-09 21:53 ` Olof Johansson
2007-12-10 16:42 ` Scott Wood
2007-12-10 18:06 ` Jon Smirl
2007-12-10 18:37 ` Scott Wood
2007-12-10 18:52 ` Jon Smirl
2007-12-10 20:35 ` Benjamin Herrenschmidt
2007-12-10 20:32 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2007-12-09 23:36 Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071203233752.GA7041@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=i2c@lm-sensors$(echo .)org \
--cc=jonsmirl@gmail$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox