* [PATCH 1/2] [RESEND] ps3: vuart: fix error path locking
[not found] <20071216181705.714358296@mvista.com>
@ 2007-12-16 8:00 ` Daniel Walker
0 siblings, 0 replies; only message in thread
From: Daniel Walker @ 2007-12-16 8:00 UTC (permalink / raw)
To: akpm
Cc: matthias.kaehlcke, linux-kernel, linux, linuxppc-dev, mingo,
kjwinchester
This stray down would cause a permanent sleep which doesn't seem correct.
The other uses of this semaphore appear fairly mutex like it's even initialized
with init_MUTEX() .. So here a patch for removing this one down().
Signed-off-by: Geoff Levand <geoffrey.levand@am•sony.com>
Signed-off-by: Daniel Walker <dwalker@mvista•com>
---
drivers/ps3/ps3-vuart.c | 1 -
1 file changed, 1 deletion(-)
Index: linux-2.6.23/drivers/ps3/ps3-vuart.c
===================================================================
--- linux-2.6.23.orig/drivers/ps3/ps3-vuart.c
+++ linux-2.6.23/drivers/ps3/ps3-vuart.c
@@ -1072,7 +1072,6 @@ static int ps3_vuart_probe(struct ps3_sy
if (result) {
dev_dbg(&dev->core, "%s:%d: drv->probe failed\n",
__func__, __LINE__);
- down(&vuart_bus_priv.probe_mutex);
goto fail_probe;
}
--
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-12-16 18:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20071216181705.714358296@mvista.com>
2007-12-16 8:00 ` [PATCH 1/2] [RESEND] ps3: vuart: fix error path locking Daniel Walker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox