From: Olof Johansson <olof@lixom•net>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH 1/2] [POWERPC] smp_call_function_map should be static
Date: Tue, 1 Jan 2008 15:31:35 -0600 [thread overview]
Message-ID: <20080101213135.GA1474@lixom.net> (raw)
In-Reply-To: <1199219313.6751.0.camel@pasglop>
On Wed, Jan 02, 2008 at 07:28:33AM +1100, Benjamin Herrenschmidt wrote:
>
> On Thu, 2007-12-27 at 22:08 -0600, Olof Johansson wrote:
> > smp_call_function_map should be static, and for consistency prepend it
> > with __ like other local helper functions in the same file.
> >
> > Signed-off-by: Olof Johansson <olof@lixom•net>
>
> NAK. I want it exported to other arch code, I'll need it in some stuff
> that I haven't released yet, like some BookE SMP stuff.
With the locking changes in 2/2, it will need a new exported function
that does the locking around the call to __*. With that, it'd be easier
to just merge this.
I.e. __smp_call_function_map() will be the internal (lockless) version,
and you'll end up adding a nonstatic smp_call_function_map() that does
locking and calls the __* one.
Is that OK with you?
-Olof
next prev parent reply other threads:[~2008-01-01 21:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-28 4:08 [PATCH 1/2] [POWERPC] smp_call_function_map should be static Olof Johansson
2007-12-28 4:11 ` [PATCH 2/2] [POWERPC] Make smp_send_stop() handle panic and xmon reboot Olof Johansson
2008-01-01 20:28 ` [PATCH 1/2] [POWERPC] smp_call_function_map should be static Benjamin Herrenschmidt
2008-01-01 21:31 ` Olof Johansson [this message]
2008-01-01 22:48 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080101213135.GA1474@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox