From: Greg KH <greg@kroah•com>
To: Peter Korsgaard <jacmet@sunsite•dk>
Cc: linuxppc-dev@ozlabs•org, dbrownell@users•sourceforge.net,
stern@rowland•harvard.edu, linux-usb@vger•kernel.org
Subject: Re: [patch v7 3/4] USB: add Cypress c67x00 OTG controller HCD driver
Date: Tue, 19 Feb 2008 15:55:54 -0800 [thread overview]
Message-ID: <20080219235554.GA13304@kroah.com> (raw)
In-Reply-To: <20080219151149.684610000@sunsite.dk>
On Tue, Feb 19, 2008 at 04:09:19PM +0100, Peter Korsgaard wrote:
> This patch adds HCD support for the Cypress c67x00 family of devices.
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite•dk>
And it doesn't build:
CC [M] drivers/usb/c67x00/c67x00-hcd.o
distcc[2413] ERROR: compile /home/gregkh/.ccache/c67x00-hcd.tmp.mini.2409.i on localhost failed
drivers/usb/c67x00/c67x00-hcd.c:345: error: redefinition of 'c67x00_hcd_probe'
drivers/usb/c67x00/c67x00-hcd.h:119: error: previous definition of 'c67x00_hcd_probe' was here
drivers/usb/c67x00/c67x00-hcd.c:402: error: redefinition of 'c67x00_hcd_remove'
drivers/usb/c67x00/c67x00-hcd.h:126: error: previous definition of 'c67x00_hcd_remove' was here
make[2]: *** [drivers/usb/c67x00/c67x00-hcd.o] Error 1
make[1]: *** [drivers/usb/c67x00] Error 2
make: *** [_module_drivers/usb] Error 2
This is _after_ removing the obviously incorrect usb_disabled()
function that you included in your .h file.
I'm going to hold off applying any of these for now, as it doesn't look
like something is configured properly here.
thanks,
greg k-h
next prev parent reply other threads:[~2008-02-19 23:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 15:09 [patch v7 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support Peter Korsgaard
2008-02-19 15:09 ` [patch v7 1/4] USB: add Cypress c67x00 low level interface code Peter Korsgaard
2008-02-19 15:09 ` [patch v7 2/4] USB: add Cypress c67x00 OTG controller core driver Peter Korsgaard
2008-02-19 15:09 ` [patch v7 3/4] USB: add Cypress c67x00 OTG controller HCD driver Peter Korsgaard
2008-02-19 23:55 ` Greg KH [this message]
2008-02-20 9:01 ` Peter Korsgaard
2008-02-20 16:16 ` Greg KH
2008-02-20 16:57 ` Peter Korsgaard
2008-02-20 17:03 ` Greg KH
2008-02-20 18:07 ` David Brownell
2008-02-20 18:29 ` Greg KH
2008-02-20 19:25 ` Peter Korsgaard
2008-02-19 15:09 ` [patch v7 4/4] USB: add Cypress c67x00 OTG controller gadget driver Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080219235554.GA13304@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=dbrownell@users$(echo .)sourceforge.net \
--cc=jacmet@sunsite$(echo .)dk \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=stern@rowland$(echo .)harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox