From: Greg KH <greg@kroah•com>
To: Peter Korsgaard <jacmet@sunsite•dk>
Cc: linuxppc-dev@ozlabs•org, dbrownell@users•sourceforge.net,
stern@rowland•harvard.edu, linux-usb@vger•kernel.org
Subject: Re: [patch v7 3/4] USB: add Cypress c67x00 OTG controller HCD driver
Date: Wed, 20 Feb 2008 08:16:08 -0800 [thread overview]
Message-ID: <20080220161608.GE2658@kroah.com> (raw)
In-Reply-To: <87bq6cf1cb.fsf@macbook.be.48ers.dk>
On Wed, Feb 20, 2008 at 10:01:40AM +0100, Peter Korsgaard wrote:
> >>>>> "Greg" == Greg KH <greg@kroah•com> writes:
>
> Greg> On Tue, Feb 19, 2008 at 04:09:19PM +0100, Peter Korsgaard wrote:
> >> This patch adds HCD support for the Cypress c67x00 family of devices.
> >>
> >> Signed-off-by: Peter Korsgaard <jacmet@sunsite•dk>
>
> Greg> And it doesn't build:
>
> Greg> CC [M] drivers/usb/c67x00/c67x00-hcd.o
> Greg> distcc[2413] ERROR: compile /home/gregkh/.ccache/c67x00-hcd.tmp.mini.2409.i on localhost failed
> Greg> drivers/usb/c67x00/c67x00-hcd.c:345: error: redefinition of 'c67x00_hcd_probe'
> Greg> drivers/usb/c67x00/c67x00-hcd.h:119: error: previous definition of 'c67x00_hcd_probe' was here
> Greg> drivers/usb/c67x00/c67x00-hcd.c:402: error: redefinition of 'c67x00_hcd_remove'
> Greg> drivers/usb/c67x00/c67x00-hcd.h:126: error: previous definition of 'c67x00_hcd_remove' was here
> Greg> make[2]: *** [drivers/usb/c67x00/c67x00-hcd.o] Error 1
> Greg> make[1]: *** [drivers/usb/c67x00] Error 2
> Greg> make: *** [_module_drivers/usb] Error 2
>
> Huh, that doesn't make any sense to me. The dumy definitions of
> c67x00_hcd_{probe,remove} are protected by an ifndef
> CONFIG_USB_C67X00_HCD, and c67x00-hcd.c which contains the real
> definitions only gets compiled if CONFIG_USB_C67X00_HCD is
> enabled. Could you perhaps provide some more details?
I don't know, I selected the config option, and yet, it built as if it
wasn't set.
> Anyway, the conditional hcd stuff isn't really needed at this point in
> the patch series, so I have moved it into patch 4 in the v8 series
> I'll post in a minute.
That's good.
> Greg> This is _after_ removing the obviously incorrect usb_disabled()
> Greg> function that you included in your .h file.
>
> That was again for conditional hcd/udc support. I have now moved the
> check into _hcd_probe() instead.
>
> Greg> I'm going to hold off applying any of these for now, as it
> Greg> doesn't look like something is configured properly here.
>
> Could you give the v8 series a try please?
Can you move the files under the hcd/ subdir, run it through
checkpatch.pl and fix up the __FUNCTION__ warnings, and then I'll be
willing to test it again :)
thanks,
greg k-h
next prev parent reply other threads:[~2008-02-20 16:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 15:09 [patch v7 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support Peter Korsgaard
2008-02-19 15:09 ` [patch v7 1/4] USB: add Cypress c67x00 low level interface code Peter Korsgaard
2008-02-19 15:09 ` [patch v7 2/4] USB: add Cypress c67x00 OTG controller core driver Peter Korsgaard
2008-02-19 15:09 ` [patch v7 3/4] USB: add Cypress c67x00 OTG controller HCD driver Peter Korsgaard
2008-02-19 23:55 ` Greg KH
2008-02-20 9:01 ` Peter Korsgaard
2008-02-20 16:16 ` Greg KH [this message]
2008-02-20 16:57 ` Peter Korsgaard
2008-02-20 17:03 ` Greg KH
2008-02-20 18:07 ` David Brownell
2008-02-20 18:29 ` Greg KH
2008-02-20 19:25 ` Peter Korsgaard
2008-02-19 15:09 ` [patch v7 4/4] USB: add Cypress c67x00 OTG controller gadget driver Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080220161608.GE2658@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=dbrownell@users$(echo .)sourceforge.net \
--cc=jacmet@sunsite$(echo .)dk \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=stern@rowland$(echo .)harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox