From: Scott Wood <scottwood@freescale•com>
To: Alexandr Smirnov <asmirnov@ru•mvista.com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 2/4] Emerson KSI8560 device tree
Date: Thu, 28 Feb 2008 13:12:30 -0600 [thread overview]
Message-ID: <20080228191230.GB3897@loki.buserror.net> (raw)
In-Reply-To: <20080228184727.GC26971@ru.mvista.com>
On Thu, Feb 28, 2008 at 09:47:27PM +0300, Alexandr Smirnov wrote:
> + soc@fdf00000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + device_type = "soc";
> + ranges = <0x00000000 0xfdf00000 0x00100000>;
> + reg = <0xfdf00000 0x200>;
The reg property is no longer needed here.
> + mdio@24520 { /* For TSECs */
> + #address-cells = <1>;
> + #size-cells = <0>;
> + device_type = "mdio";
> + compatible = "gianfar";
No device_type, compatible should be "fsl,gianfar-mdio".
> + localbus@fdf05000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "fsl,mpc8560-localbus";
> + reg = <0xfdf05000 0x68>;
> +
> + ranges = <0xe0000000 0xe0000000 0x00800000>;
The localbus node isn't just a container for flash; if you're not going to
use the chipselect mechanism (and you should), then at least use a blank
"ranges;".
> + cpld@e8080000 {
> + compatible = "altera,maxii";
> + reg = <0xe8080000 0x80000>;
> + };
Should this go under the localbus node?
-Scott
next prev parent reply other threads:[~2008-02-28 19:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 18:35 [PATCH 0/0] Add Emerson KSI8560 board support Alexandr Smirnov
2008-02-28 18:44 ` [PATCH 1/4] Emerson KSI8560 bootwrapper Alexandr Smirnov
2008-02-29 2:11 ` Stephen Rothwell
2008-02-28 18:47 ` [PATCH 2/4] Emerson KSI8560 device tree Alexandr Smirnov
2008-02-28 19:12 ` Scott Wood [this message]
2008-02-29 2:17 ` David Gibson
2008-02-28 18:50 ` [PATCH 3/4] Emerson KSI8560 default config Alexandr Smirnov
2008-02-28 18:52 ` [PATCH 4/4] Emerson KSI8560 base support Alexandr Smirnov
2008-02-29 2:34 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080228191230.GB3897@loki.buserror.net \
--to=scottwood@freescale$(echo .)com \
--cc=asmirnov@ru$(echo .)mvista.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox