From: David Gibson <david@gibson•dropbear.id.au>
To: Alexandr Smirnov <asmirnov@ru•mvista.com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 1/4] Emerson ATCA-C125 bootwrapper
Date: Sat, 15 Mar 2008 11:10:36 +1100 [thread overview]
Message-ID: <20080315001036.GA3487@localhost.localdomain> (raw)
In-Reply-To: <20080314142703.GB8228@ru.mvista.com>
On Fri, Mar 14, 2008 at 05:27:03PM +0300, Alexandr Smirnov wrote:
>
> Bootwraper for Emerson ATCA-C125 board. This board has
> four ethernet ports, so it has to use this code instead
> of generic.
[snip]
> + /* Unfortunately, the specific model number is encoded in the
> + * soc node name in existing dts files -- once that is fixed,
> + * this can do a simple path lookup.
> + */
Since this is a new board, couldn't you name the soc node /soc and
dispense with this more complicated way of doing things? Or would
that break other versions of u-boot that are in use?
> + soc = find_node_by_devtype(NULL, "soc");
> + if (soc) {
> + void *serial = NULL;
> +
> + setprop(soc, "bus-frequency", &bd.bi_busfreq,
> + sizeof(bd.bi_busfreq));
> +
> + while ((serial = find_node_by_devtype(serial, "serial"))) {
> + if (get_parent(serial) != soc)
> + continue;
> +
> + setprop(serial, "clock-frequency", &bd.bi_busfreq,
> + sizeof(bd.bi_busfreq));
> + }
> + }
> +}
> +
> +void platform_init(unsigned long r3, unsigned long r4, unsigned long r5,
> + unsigned long r6, unsigned long r7)
> +{
> + CUBOOT_INIT();
> + fdt_init(_dtb_start);
> + serial_console_init();
> + platform_ops.fixups = platform_fixups;
> +}
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2008-03-15 0:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 14:22 PATCH [0/4] Add support for Emerson ATCA-C125 board Alexandr Smirnov
2008-03-14 14:27 ` [PATCH 1/4] Emerson ATCA-C125 bootwrapper Alexandr Smirnov
2008-03-15 0:10 ` David Gibson [this message]
2008-03-17 12:19 ` Alexandr Smirnov
2008-03-18 1:28 ` David Gibson
2008-03-14 14:28 ` [PATCH 2/4] Emerson ATCA-C125 device tree Alexandr Smirnov
2008-03-14 14:29 ` [PATCH 3/4] Emerson ATCA-C125 default config Alexandr Smirnov
2008-03-14 14:30 ` [PATCH 4/4] Emerson ATCA-C125 base support Alexandr Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080315001036.GA3487@localhost.localdomain \
--to=david@gibson$(echo .)dropbear.id.au \
--cc=asmirnov@ru$(echo .)mvista.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox