From: "Gerhard Pircher" <gerhard_pircher@gmx•net>
To: Anton Vorontsov <avorontsov@ru•mvista.com>, galak@kernel•crashing.org
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 1/2] [POWERPC] rtc_cmos_setup: assign interrupts only if there is i8259 PIC
Date: Tue, 06 May 2008 10:19:14 +0200 [thread overview]
Message-ID: <20080506081914.269180@gmx.net> (raw)
In-Reply-To: <20080505185538.GA4906@polina.dev.rtsoft.ru>
-------- Original-Nachricht --------
> Datum: Mon, 5 May 2008 22:55:38 +0400
> Von: Anton Vorontsov <avorontsov@ru•mvista.com>
> An: Kumar Gala <galak@kernel•crashing.org>
> CC: linuxppc-dev@ozlabs•org
> Betreff: [PATCH 1/2] [POWERPC] rtc_cmos_setup: assign interrupts only if there is i8259 PIC
> Sometimes (particularly on MPC8610HPCD) we want IRQ-less CMOS RTC for
> the boards without (or disabled) i8259 PICs.
>
> We lookup the device tree for "chrp,iic" compatible devices, and if not
> found we do not assign RTC IRQ.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru•mvista.com>
> ---
> arch/powerpc/sysdev/rtc_cmos_setup.c | 21 +++++++++++++++------
> 1 files changed, 15 insertions(+), 6 deletions(-)
>
> diff --git a/arch/powerpc/sysdev/rtc_cmos_setup.c
> b/arch/powerpc/sysdev/rtc_cmos_setup.c
> index c09ddc0..e5d0bcb 100644
> --- a/arch/powerpc/sysdev/rtc_cmos_setup.c
> +++ b/arch/powerpc/sysdev/rtc_cmos_setup.c
> @@ -21,6 +21,7 @@ static int __init add_rtc(void)
> struct device_node *np;
> struct platform_device *pd;
> struct resource res[2];
> + unsigned int num_res = 1;
> int ret;
>
> memset(&res, 0, sizeof(res));
> @@ -41,14 +42,22 @@ static int __init add_rtc(void)
> if (res[0].start != RTC_PORT(0))
> return -EINVAL;
>
> - /* Use a fixed interrupt value of 8 since on PPC if we are using this
> - * its off an i8259 which we ensure has interrupt numbers 0..15. */
> - res[1].start = 8;
> - res[1].end = 8;
> - res[1].flags = IORESOURCE_IRQ;
> + np = of_find_compatible_node(NULL, NULL, "chrp,iic");
Could you add a check for "pnpPNP,000" (PNP ID for i8259), as not all
platforms use the CHRP names?
Gerhard
--
249 Spiele für nur 1 Preis. Die GMX Spieleflatrate schon ab 9,90 Euro.
Neu: Asterix bei den Olympischen Spielen: http://flat.games.gmx.de
next prev parent reply other threads:[~2008-05-06 8:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 18:55 [PATCH 1/2] [POWERPC] rtc_cmos_setup: assign interrupts only if there is i8259 PIC Anton Vorontsov
2008-05-06 8:06 ` Gabriel Paubert
2008-06-03 12:21 ` Anton Vorontsov
2008-05-06 8:19 ` Gerhard Pircher [this message]
2008-06-03 12:21 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080506081914.269180@gmx.net \
--to=gerhard_pircher@gmx$(echo .)net \
--cc=avorontsov@ru$(echo .)mvista.com \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox