From: Anton Vorontsov <avorontsov@ru•mvista.com>
To: Gerhard Pircher <gerhard_pircher@gmx•net>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 1/2] [POWERPC] rtc_cmos_setup: assign interrupts only if there is i8259 PIC
Date: Tue, 3 Jun 2008 16:21:55 +0400 [thread overview]
Message-ID: <20080603122155.GB2407@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <20080506081914.269180@gmx.net>
On Tue, May 06, 2008 at 10:19:14AM +0200, Gerhard Pircher wrote:
>
> -------- Original-Nachricht --------
> > Datum: Mon, 5 May 2008 22:55:38 +0400
> > Von: Anton Vorontsov <avorontsov@ru•mvista.com>
> > An: Kumar Gala <galak@kernel•crashing.org>
> > CC: linuxppc-dev@ozlabs•org
> > Betreff: [PATCH 1/2] [POWERPC] rtc_cmos_setup: assign interrupts only if there is i8259 PIC
>
> > Sometimes (particularly on MPC8610HPCD) we want IRQ-less CMOS RTC for
> > the boards without (or disabled) i8259 PICs.
> >
> > We lookup the device tree for "chrp,iic" compatible devices, and if not
> > found we do not assign RTC IRQ.
> >
> > Signed-off-by: Anton Vorontsov <avorontsov@ru•mvista.com>
> > ---
> > arch/powerpc/sysdev/rtc_cmos_setup.c | 21 +++++++++++++++------
> > 1 files changed, 15 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/powerpc/sysdev/rtc_cmos_setup.c
> > b/arch/powerpc/sysdev/rtc_cmos_setup.c
> > index c09ddc0..e5d0bcb 100644
> > --- a/arch/powerpc/sysdev/rtc_cmos_setup.c
> > +++ b/arch/powerpc/sysdev/rtc_cmos_setup.c
> > @@ -21,6 +21,7 @@ static int __init add_rtc(void)
> > struct device_node *np;
> > struct platform_device *pd;
> > struct resource res[2];
> > + unsigned int num_res = 1;
> > int ret;
> >
> > memset(&res, 0, sizeof(res));
> > @@ -41,14 +42,22 @@ static int __init add_rtc(void)
> > if (res[0].start != RTC_PORT(0))
> > return -EINVAL;
> >
> > - /* Use a fixed interrupt value of 8 since on PPC if we are using this
> > - * its off an i8259 which we ensure has interrupt numbers 0..15. */
> > - res[1].start = 8;
> > - res[1].end = 8;
> > - res[1].flags = IORESOURCE_IRQ;
> > + np = of_find_compatible_node(NULL, NULL, "chrp,iic");
> Could you add a check for "pnpPNP,000" (PNP ID for i8259), as not all
> platforms use the CHRP names?
Ok, will do.
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail•com
irc://irc.freenode.net/bd2
prev parent reply other threads:[~2008-06-03 12:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 18:55 [PATCH 1/2] [POWERPC] rtc_cmos_setup: assign interrupts only if there is i8259 PIC Anton Vorontsov
2008-05-06 8:06 ` Gabriel Paubert
2008-06-03 12:21 ` Anton Vorontsov
2008-05-06 8:19 ` Gerhard Pircher
2008-06-03 12:21 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080603122155.GB2407@polina.dev.rtsoft.ru \
--to=avorontsov@ru$(echo .)mvista.com \
--cc=gerhard_pircher@gmx$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox