From: Dave Jones <davej@codemonkey•org.uk>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Arnd Bergmann <arnd@arndb•de>,
cpufreq@lists•linux.org.uk, linuxppc-dev@ozlabs•org,
Jeremy Kerr <jk@ozlabs•org>,
cbe-oss-dev@ozlabs•org
Subject: Re: powerpc/cell/cpufreq: add spu aware cpufreq governor
Date: Wed, 9 Jul 2008 02:29:58 -0400 [thread overview]
Message-ID: <20080709062958.GA24570@codemonkey.org.uk> (raw)
In-Reply-To: <1215580739.8970.317.camel@pasglop>
On Wed, Jul 09, 2008 at 03:18:59PM +1000, Ben Herrenschmidt wrote:
> On Mon, 2008-07-07 at 17:02 +0200, Arnd Bergmann wrote:
> > From: Christian Krafft <krafft@de•ibm.com>
> >
> > This patch adds a cpufreq governor that takes the number of running spus
> > into account. It's very similar to the ondemand governor, but not as complex.
> > Instead of hacking spu load into the ondemand governor it might be easier to
> > have cpufreq accepting multiple governors per cpu in future.
> > Don't know if this is the right way, but it would keep the governors simple.
> >
> > Signed-off-by: Christian Krafft <krafft@de•ibm.com>
> > Signed-off-by: Arnd Bergmann <arnd@arndb•de>
> > ---
> >
> > Dave or other cpufreq people, can you take a look at this
> > and add an Acked-by when you're happy?
> >
> > We have one prerequisite patch in the powerpc code (in spufs),
> > so should it get merged through powerpc.git?
>
> Hrm... taking whatever test config I have at hand, applying the patch
> and doing make oldconfig & make, I get:
>
> ERROR: ".cpufreq_register_governor" [arch/powerpc/platforms/cell/cbe_spu_governor.ko] undefined!
> ERROR: ".__cpufreq_driver_target" [arch/powerpc/platforms/cell/cbe_spu_governor.ko] undefined!
> ERROR: ".cpufreq_unregister_governor" [arch/powerpc/platforms/cell/cbe_spu_governor.ko] undefined!
> ERROR: ".cpufreq_frequency_table_target" [arch/powerpc/platforms/cell/cbe-cpufreq.ko] undefined!
> ERROR: ".cpufreq_register_driver" [arch/powerpc/platforms/cell/cbe-cpufreq.ko] undefined!
> ERROR: ".cpufreq_frequency_table_verify" [arch/powerpc/platforms/cell/cbe-cpufreq.ko] undefined!
> ERROR: ".cpufreq_frequency_table_get_attr" [arch/powerpc/platforms/cell/cbe-cpufreq.ko] undefined!
> ERROR: ".cpufreq_notify_transition" [arch/powerpc/platforms/cell/cbe-cpufreq.ko] undefined!
> ERROR: ".cpufreq_frequency_table_cpuinfo" [arch/powerpc/platforms/cell/cbe-cpufreq.ko] undefined!
> ERROR: ".cpufreq_unregister_driver" [arch/powerpc/platforms/cell/cbe-cpufreq.ko] undefined!
> ERROR: ".cpufreq_frequency_table_put_attr" [arch/powerpc/platforms/cell/cbe-cpufreq.ko] undefined!
Does this help ?
Dave
diff --git a/arch/powerpc/platforms/cell/Kconfig b/arch/powerpc/platforms/cell/Kconfig
index 3959fcf..19f4b4d 100644
--- a/arch/powerpc/platforms/cell/Kconfig
+++ b/arch/powerpc/platforms/cell/Kconfig
@@ -91,6 +91,7 @@ config CBE_THERM
config CBE_CPUFREQ
tristate "CBE frequency scaling"
depends on CBE_RAS && CPU_FREQ
+ select CPU_FREQ_TABLE
default m
help
This adds the cpufreq driver for Cell BE processors.
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2008-07-09 6:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 15:02 powerpc/cell/cpufreq: add spu aware cpufreq governor Arnd Bergmann
2008-07-07 17:17 ` [Cbe-oss-dev] " Eric Blossom
2008-07-07 21:02 ` Arnd Bergmann
2008-07-07 21:31 ` Dave Jones
2008-07-08 6:43 ` Arnd Bergmann
2008-07-08 15:27 ` Dave Jones
2008-07-09 3:41 ` Benjamin Herrenschmidt
2008-07-09 3:57 ` Dave Jones
2008-07-10 18:05 ` Dominik Brodowski
2008-07-10 21:05 ` Arnd Bergmann
2008-07-10 21:16 ` Dominik Brodowski
2008-07-09 5:18 ` Benjamin Herrenschmidt
2008-07-09 6:29 ` Dave Jones [this message]
2008-07-15 13:02 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080709062958.GA24570@codemonkey.org.uk \
--to=davej@codemonkey$(echo .)org.uk \
--cc=arnd@arndb$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=cbe-oss-dev@ozlabs$(echo .)org \
--cc=cpufreq@lists$(echo .)linux.org.uk \
--cc=jk@ozlabs$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox