From: Anton Vorontsov <avorontsov@ru•mvista.com>
To: Jochen Friedrich <jochen@scram•de>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] of/i2c: don't pass -1 to irq_dispose_mapping, otherwise kernel will oops
Date: Fri, 11 Jul 2008 23:19:30 +0400 [thread overview]
Message-ID: <20080711191930.GA23723@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <4877B046.8070206@scram.de>
On Fri, Jul 11, 2008 at 09:11:02PM +0200, Jochen Friedrich wrote:
> Hi Anton,
>
> > diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c
> > index b2ccdcb..95a24de 100644
> > --- a/drivers/of/of_i2c.c
> > +++ b/drivers/of/of_i2c.c
> > @@ -93,10 +93,8 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
> > if (info.irq == NO_IRQ)
> > info.irq = -1;
> >
> > - if (of_find_i2c_driver(node, &info) < 0) {
> > - irq_dispose_mapping(info.irq);
> > - continue;
> > - }
> > + if (of_find_i2c_driver(node, &info) < 0)
> > + goto err;
> >
> > info.addr = *addr;
> >
> > @@ -107,9 +105,12 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
> > printk(KERN_ERR
> > "of-i2c: Failed to load driver for %s\n",
> > info.type);
> > - irq_dispose_mapping(info.irq);
> > - continue;
> > + goto err;
> > }
> > + continue;
> > +err:
> > + if (info.irq > 0)
> > + irq_dispose_mapping(info.irq);
>
> Shouldn't this be:
> if (info.irq != NO_IRQ)
Maybe, maybe not. See
http://lkml.org/lkml/2005/11/21/211
I.e. maybe we should use "if (irq)". Or if we should use NO_IRQ, then we
need to fixup all the users of .irq.
--
Anton Vorontsov
email: cbouatmailru@gmail•com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2008-07-11 19:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 17:48 [PATCH] of/i2c: don't pass -1 to irq_dispose_mapping, otherwise kernel will oops Anton Vorontsov
2008-07-11 18:14 ` Anton Vorontsov
2008-07-11 18:23 ` Grant Likely
2008-07-11 18:55 ` Anton Vorontsov
2008-07-11 19:01 ` Jochen Friedrich
2008-07-11 19:15 ` Anton Vorontsov
2008-07-12 8:22 ` [i2c] " Wolfram Sang
2008-07-12 8:00 ` Wolfram Sang
2008-07-13 3:59 ` Jon Smirl
2008-07-16 22:20 ` Grant Likely
2008-07-11 19:11 ` Jochen Friedrich
2008-07-11 19:19 ` Anton Vorontsov [this message]
2008-07-11 21:18 ` Grant Likely
2008-07-11 21:46 ` Anton Vorontsov
2008-07-11 22:08 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080711191930.GA23723@polina.dev.rtsoft.ru \
--to=avorontsov@ru$(echo .)mvista.com \
--cc=jochen@scram$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox