From: Grant Likely <grant.likely@secretlab•ca>
To: Anton Vorontsov <avorontsov@ru•mvista.com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] of/i2c: don't pass -1 to irq_dispose_mapping, otherwise kernel will oops
Date: Fri, 11 Jul 2008 16:08:26 -0600 [thread overview]
Message-ID: <20080711220826.GD18239@secretlab.ca> (raw)
In-Reply-To: <20080711214614.GA22000@polina.dev.rtsoft.ru>
On Sat, Jul 12, 2008 at 01:46:14AM +0400, Anton Vorontsov wrote:
> On Fri, Jul 11, 2008 at 03:18:13PM -0600, Grant Likely wrote:
> > On Fri, Jul 11, 2008 at 11:19:30PM +0400, Anton Vorontsov wrote:
> > > On Fri, Jul 11, 2008 at 09:11:02PM +0200, Jochen Friedrich wrote:
> > > >
> > > > Shouldn't this be:
> > > > if (info.irq != NO_IRQ)
> > >
> > > Maybe, maybe not. See
> > >
> > > http://lkml.org/lkml/2005/11/21/211
> > >
> > > I.e. maybe we should use "if (irq)". Or if we should use NO_IRQ, then we
> > > need to fixup all the users of .irq.
> >
> > Yes, these are definitely wrong and need to be fixed.
>
> In rc9? ;-)
I said no such thing. :-) It agree that it is too late for .26, but I
think is a reasonable goal to get fixed for 2.6.27.
g.
prev parent reply other threads:[~2008-07-11 22:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 17:48 [PATCH] of/i2c: don't pass -1 to irq_dispose_mapping, otherwise kernel will oops Anton Vorontsov
2008-07-11 18:14 ` Anton Vorontsov
2008-07-11 18:23 ` Grant Likely
2008-07-11 18:55 ` Anton Vorontsov
2008-07-11 19:01 ` Jochen Friedrich
2008-07-11 19:15 ` Anton Vorontsov
2008-07-12 8:22 ` [i2c] " Wolfram Sang
2008-07-12 8:00 ` Wolfram Sang
2008-07-13 3:59 ` Jon Smirl
2008-07-16 22:20 ` Grant Likely
2008-07-11 19:11 ` Jochen Friedrich
2008-07-11 19:19 ` Anton Vorontsov
2008-07-11 21:18 ` Grant Likely
2008-07-11 21:46 ` Anton Vorontsov
2008-07-11 22:08 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080711220826.GD18239@secretlab.ca \
--to=grant.likely@secretlab$(echo .)ca \
--cc=avorontsov@ru$(echo .)mvista.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox