From: Arnd Bergmann <arnd@arndb•de>
To: Sean MacLennan <smaclennan@pikatech•com>
Cc: linuxppc-dev@ozlabs•org, dwmw2@infradead•org
Subject: Re: [PATCH 1/2] port ndfc driver to of platform
Date: Fri, 15 Aug 2008 09:27:41 +0200 [thread overview]
Message-ID: <200808150927.41993.arnd@arndb.de> (raw)
In-Reply-To: <20080814191041.60ffed5c@lappy.seanm.ca>
On Friday 15 August 2008, Sean MacLennan wrote:
> Port the ndfc driver to an OF platform driver.
>
> Signed-off-by: Sean MacLennan <smaclennan@pikatech•com>
Acked-by: Arnd Bergmann <arnd@arndb•de>
Looks great, but I just noticed one more detail:
> +static const struct of_device_id ndfc_match[] = {
> + { .compatible = "amcc,ndfc", },
> + {}
> };
>
You should add
MODULE_DEVICE_TABLE(of, &ndfc_match);
to enable module auto-loading.
Arnd <><
next prev parent reply other threads:[~2008-08-15 7:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-02 3:30 [PATCH] port ndfc driver to arch/powerpc Sean MacLennan
2008-08-04 16:25 ` Arnd Bergmann
2008-08-04 17:24 ` Sean MacLennan
2008-08-13 21:36 ` [PATCH 1/2] port ndfc driver to of platform Sean MacLennan
2008-08-14 9:53 ` Arnd Bergmann
2008-08-14 16:08 ` Sean MacLennan
2008-08-14 17:21 ` Sean MacLennan
2008-08-14 20:16 ` Arnd Bergmann
2008-08-14 20:54 ` Sean MacLennan
2008-08-14 23:10 ` Sean MacLennan
2008-08-15 7:27 ` Arnd Bergmann [this message]
2008-08-15 17:29 ` Sean MacLennan
2008-08-13 21:45 ` [PATCH 2/2] " Sean MacLennan
2008-08-14 10:08 ` Arnd Bergmann
2008-08-14 16:32 ` Jon Loeliger
2008-08-14 23:20 ` Sean MacLennan
2008-08-15 5:24 ` Sean MacLennan
2008-08-15 7:28 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808150927.41993.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=dwmw2@infradead$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=smaclennan@pikatech$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox