From: Jens Axboe <jens.axboe@oracle•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Paul Mackerras <paulus@samba•org>, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc/iseries: viodasd needs to depend on CONFIG_BLOCK
Date: Wed, 17 Dec 2008 09:02:11 +0100 [thread overview]
Message-ID: <20081217080211.GB32491@kernel.dk> (raw)
In-Reply-To: <20081217171649.f3cd7c96.sfr@canb.auug.org.au>
On Wed, Dec 17 2008, Stephen Rothwell wrote:
> Otherwise you get lot of errors like these:
>
> drivers/block/viodasd.c:72: error: dereferencing pointer to incomplete type
> drivers/block/viodasd.c: In function 'viodasd_open':
> drivers/block/viodasd.c:135: error: dereferencing pointer to incomplete type
> drivers/block/viodasd.c: In function 'viodasd_release':
> drivers/block/viodasd.c:184: error: dereferencing pointer to incomplete type
> drivers/block/viodasd.c: In function 'viodasd_getgeo':
> drivers/block/viodasd.c:209: error: dereferencing pointer to incomplete type
> drivers/block/viodasd.c:214: error: implicit declaration of function 'get_capacity'
> drivers/block/viodasd.c: At top level:
> drivers/block/viodasd.c:222: error: variable 'viodasd_fops' has initializer but incomplete type
> drivers/block/viodasd.c:223: error: unknown field 'owner' specified in initializer
>
> Discovered by a randconfig build.
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
> arch/powerpc/platforms/iseries/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/platforms/iseries/Kconfig b/arch/powerpc/platforms/iseries/Kconfig
> index 45ffd8e..ed3753d 100644
> --- a/arch/powerpc/platforms/iseries/Kconfig
> +++ b/arch/powerpc/platforms/iseries/Kconfig
> @@ -9,6 +9,7 @@ menu "iSeries device drivers"
>
> config VIODASD
> tristate "iSeries Virtual I/O disk support"
> + depends on BLOCK
> help
> If you are running on an iSeries system and you want to use
> virtual disks created and managed by OS/400, say Y.
> --
> 1.6.0.5
Indeed, looks good. I trust the ppc folks will carry this one? If so,
feel free to add my acked-by to this.
--
Jens Axboe
next prev parent reply other threads:[~2008-12-17 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 6:16 [PATCH] powerpc/iseries: viodasd needs to depend on CONFIG_BLOCK Stephen Rothwell
2008-12-17 8:02 ` Jens Axboe [this message]
2008-12-17 8:24 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081217080211.GB32491@kernel.dk \
--to=jens.axboe@oracle$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox