* [PATCH] powerpc/iseries: viodasd needs to depend on CONFIG_BLOCK
@ 2008-12-17 6:16 Stephen Rothwell
2008-12-17 8:02 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2008-12-17 6:16 UTC (permalink / raw)
To: Paul Mackerras, Benjamin Herrenschmidt; +Cc: linuxppc-dev, Jens Axboe
Otherwise you get lot of errors like these:
drivers/block/viodasd.c:72: error: dereferencing pointer to incomplete type
drivers/block/viodasd.c: In function 'viodasd_open':
drivers/block/viodasd.c:135: error: dereferencing pointer to incomplete type
drivers/block/viodasd.c: In function 'viodasd_release':
drivers/block/viodasd.c:184: error: dereferencing pointer to incomplete type
drivers/block/viodasd.c: In function 'viodasd_getgeo':
drivers/block/viodasd.c:209: error: dereferencing pointer to incomplete type
drivers/block/viodasd.c:214: error: implicit declaration of function 'get_capacity'
drivers/block/viodasd.c: At top level:
drivers/block/viodasd.c:222: error: variable 'viodasd_fops' has initializer but incomplete type
drivers/block/viodasd.c:223: error: unknown field 'owner' specified in initializer
Discovered by a randconfig build.
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
arch/powerpc/platforms/iseries/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/platforms/iseries/Kconfig b/arch/powerpc/platforms/iseries/Kconfig
index 45ffd8e..ed3753d 100644
--- a/arch/powerpc/platforms/iseries/Kconfig
+++ b/arch/powerpc/platforms/iseries/Kconfig
@@ -9,6 +9,7 @@ menu "iSeries device drivers"
config VIODASD
tristate "iSeries Virtual I/O disk support"
+ depends on BLOCK
help
If you are running on an iSeries system and you want to use
virtual disks created and managed by OS/400, say Y.
--
1.6.0.5
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/iseries: viodasd needs to depend on CONFIG_BLOCK
2008-12-17 6:16 [PATCH] powerpc/iseries: viodasd needs to depend on CONFIG_BLOCK Stephen Rothwell
@ 2008-12-17 8:02 ` Jens Axboe
2008-12-17 8:24 ` Stephen Rothwell
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2008-12-17 8:02 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Paul Mackerras, linuxppc-dev
On Wed, Dec 17 2008, Stephen Rothwell wrote:
> Otherwise you get lot of errors like these:
>
> drivers/block/viodasd.c:72: error: dereferencing pointer to incomplete type
> drivers/block/viodasd.c: In function 'viodasd_open':
> drivers/block/viodasd.c:135: error: dereferencing pointer to incomplete type
> drivers/block/viodasd.c: In function 'viodasd_release':
> drivers/block/viodasd.c:184: error: dereferencing pointer to incomplete type
> drivers/block/viodasd.c: In function 'viodasd_getgeo':
> drivers/block/viodasd.c:209: error: dereferencing pointer to incomplete type
> drivers/block/viodasd.c:214: error: implicit declaration of function 'get_capacity'
> drivers/block/viodasd.c: At top level:
> drivers/block/viodasd.c:222: error: variable 'viodasd_fops' has initializer but incomplete type
> drivers/block/viodasd.c:223: error: unknown field 'owner' specified in initializer
>
> Discovered by a randconfig build.
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
> arch/powerpc/platforms/iseries/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/platforms/iseries/Kconfig b/arch/powerpc/platforms/iseries/Kconfig
> index 45ffd8e..ed3753d 100644
> --- a/arch/powerpc/platforms/iseries/Kconfig
> +++ b/arch/powerpc/platforms/iseries/Kconfig
> @@ -9,6 +9,7 @@ menu "iSeries device drivers"
>
> config VIODASD
> tristate "iSeries Virtual I/O disk support"
> + depends on BLOCK
> help
> If you are running on an iSeries system and you want to use
> virtual disks created and managed by OS/400, say Y.
> --
> 1.6.0.5
Indeed, looks good. I trust the ppc folks will carry this one? If so,
feel free to add my acked-by to this.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/iseries: viodasd needs to depend on CONFIG_BLOCK
2008-12-17 8:02 ` Jens Axboe
@ 2008-12-17 8:24 ` Stephen Rothwell
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2008-12-17 8:24 UTC (permalink / raw)
To: Jens Axboe; +Cc: Paul Mackerras, linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
Hi Jens,
On Wed, 17 Dec 2008 09:02:11 +0100 Jens Axboe <jens.axboe@oracle•com> wrote:
>
> Indeed, looks good. I trust the ppc folks will carry this one? If so,
> feel free to add my acked-by to this.
Thanks, I would expect Paul (or Ben) to pick this up.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-12-17 8:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-17 6:16 [PATCH] powerpc/iseries: viodasd needs to depend on CONFIG_BLOCK Stephen Rothwell
2008-12-17 8:02 ` Jens Axboe
2008-12-17 8:24 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox