From: "Gerhard Pircher" <gerhard_pircher@gmx•net>
To: "Grant Likely" <grant.likely@secretlab•ca>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 3/5] powerpc: Bootwrapper and serial console support for AmigaOne
Date: Wed, 07 Jan 2009 16:20:35 +0100 [thread overview]
Message-ID: <20090107152035.270110@gmx.net> (raw)
In-Reply-To: <fa686aa40901070707h6c10186bv6c7953e7a63c9f3f@mail.gmail.com>
-------- Original-Nachricht --------
> Datum: Wed, 7 Jan 2009 08:07:14 -0700
> Von: "Grant Likely" <grant.likely@secretlab•ca>
> An: "Gerhard Pircher" <gerhard_pircher@gmx•net>
> CC: linuxppc-dev@ozlabs•org
> Betreff: Re: [PATCH 3/5] powerpc: Bootwrapper and serial console support for AmigaOne
> On Wed, Jan 7, 2009 at 7:03 AM, Gerhard Pircher <gerhard_pircher@gmx•net>
> wrote:
> > diff --git a/arch/powerpc/boot/serial.c b/arch/powerpc/boot/serial.c
> > index 8b3607c..f2156f0 100644
> > --- a/arch/powerpc/boot/serial.c
> > +++ b/arch/powerpc/boot/serial.c
> > @@ -117,7 +117,8 @@ int serial_console_init(void)
> > if (devp == NULL)
> > goto err_out;
> >
> > - if (dt_is_compatible(devp, "ns16550"))
> > + if (dt_is_compatible(devp, "ns16550") ||
> > + dt_is_compatible(devp, "pnpPNP,501"))
> > rc = ns16550_console_init(devp, &serial_cd);
>
> Why not just claim "ns16550" compatibility in the device tree node?
It was suggested that I should use PNP identifiers for all ISA devices, as
these are part of a real PCI2ISA bridge (when I sent the previous version
or these patches).
Gerhard
--
Sensationsangebot verlängert: GMX FreeDSL - Telefonanschluss + DSL
für nur 16,37 Euro/mtl.!* http://dsl.gmx.de/?ac=OM.AD.PD003K1308T4569a
next prev parent reply other threads:[~2009-01-07 15:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 13:54 [PATCH 1/5] powerpc: Add platform support for AmigaOne Gerhard Pircher
2009-01-07 14:01 ` [PATCH 2/5] powerpc: Generic device tree for all AmigaOne boards Gerhard Pircher
2009-01-07 16:41 ` Grant Likely
2009-01-07 22:10 ` Scott Wood
2009-01-07 22:21 ` Grant Likely
2009-01-07 22:23 ` Scott Wood
2009-01-07 22:36 ` Grant Likely
2009-01-07 22:38 ` Scott Wood
2009-01-12 5:07 ` Benjamin Herrenschmidt
2009-01-12 5:58 ` Grant Likely
2009-01-07 14:03 ` [PATCH 3/5] powerpc: Bootwrapper and serial console support for AmigaOne Gerhard Pircher
2009-01-07 15:07 ` Grant Likely
2009-01-07 15:20 ` Gerhard Pircher [this message]
2009-01-07 15:47 ` Grant Likely
2009-01-07 14:05 ` [PATCH 4/5] powerpc: Default config for AmigaOne boards Gerhard Pircher
2009-01-07 14:12 ` [PATCH 5/5] ide: Force VIA IDE legacy interrupts " Gerhard Pircher
2009-01-07 15:13 ` Grant Likely
2009-01-07 15:27 ` Gerhard Pircher
2009-01-11 16:51 ` Bartlomiej Zolnierkiewicz
2009-01-11 20:05 ` Gerhard Pircher
2009-01-12 17:55 ` Bartlomiej Zolnierkiewicz
2009-01-07 16:07 ` [PATCH 1/5] powerpc: Add platform support for AmigaOne Grant Likely
2009-01-07 19:07 ` Scott Wood
2009-01-07 22:50 ` [PATCH 2/5] powerpc: Generic device tree for all AmigaOne boards Gerhard Pircher
2009-01-12 5:12 ` Benjamin Herrenschmidt
2009-01-12 23:39 ` [PATCH 1/5] powerpc: Add platform support for AmigaOne Gerhard Pircher
2009-01-12 5:08 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090107152035.270110@gmx.net \
--to=gerhard_pircher@gmx$(echo .)net \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox