From: Olof Johansson <olof@lixom•net>
To: Michael Ellerman <michael@ellerman•id.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc/cell: Only build Axon MSI driver for IBM Cell Blades
Date: Thu, 5 Mar 2009 01:13:56 -0600 [thread overview]
Message-ID: <20090305071356.GA9412@lixom.net> (raw)
In-Reply-To: <e9c405aaec255c2a3d34209fc35ae093fcae8efc.1236228043.git.michael@ellerman.id.au>
On Thu, Mar 05, 2009 at 03:41:41PM +1100, Michael Ellerman wrote:
> The hardware is only present on those machines, and the driver
> depends on infrastructure which is selected by the Kconfig for
> cell blades.
Wouldn't it make more sense to make a separate (AXON_MSI) config option
depend on PPC_IBM_CELL_BLADE?
-Olof
> --- a/arch/powerpc/platforms/cell/Makefile
> +++ b/arch/powerpc/platforms/cell/Makefile
> @@ -28,7 +28,9 @@ obj-$(CONFIG_SPU_BASE) += spu_callbacks.o spu_base.o \
> $(spu-manage-y) \
> spufs/
>
> +ifeq ($(CONFIG_PPC_IBM_CELL_BLADE),y)
> obj-$(CONFIG_PCI_MSI) += axon_msi.o
> +endif
>
> # qpace setup
> obj-$(CONFIG_PPC_CELL_QPACE) += qpace_setup.o
next prev parent reply other threads:[~2009-03-05 7:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 4:41 [PATCH] powerpc/cell: Only build Axon MSI driver for IBM Cell Blades Michael Ellerman
2009-03-05 7:13 ` Olof Johansson [this message]
2009-03-05 14:07 ` Michael Ellerman
2009-03-05 20:08 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090305071356.GA9412@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=michael@ellerman$(echo .)id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox