From: Wolfram Sang <w.sang@pengutronix•de>
To: Wolfgang Grandegger <wg@grandegger•com>
Cc: linuxppc-dev@ozlabs•org, devicetree-discuss@ozlabs•org,
linux-i2c@vger•kernel.org
Subject: Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking
Date: Tue, 31 Mar 2009 15:56:29 +0200 [thread overview]
Message-ID: <20090331135629.GC3044@pengutronix.de> (raw)
In-Reply-To: <49D21EF1.9050200@grandegger.com>
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
> >> -
> >> - mpc_i2c_setclock(i2c);
> >> +
> >> + if (set_clock)
> >> + mpc_i2c_setclock(i2c);
> >
> > Can't we drop 'set_clock' with something like this here?
> >
> > + if (!of_get_property(op->node, "fsl,preserve-clocking", NULL)) {
> > +
> > + if (of_get_property(op->node, "dfsrr", NULL))
> > + i2c->flags |= FSL_I2C_DEV_SEPARATE_DFSRR;
> > +
> > + if (of_device_is_compatible(op->node, "fsl,mpc5200-i2c") ||
> > + of_device_is_compatible(op->node, "mpc5200-i2c"))
> > + i2c->flags |= FSL_I2C_DEV_CLOCK_5200;
> > +
> > + mpc_i2c_setclock(i2c);
> > + }
>
> No, because the I2C registers are not yet mapped.
Sorry, I used misleading words :) With 'here' I meant 'at this
position', i.e. insert my above block where mpc_i2c_setclock was used
anyway.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-03-31 13:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 12:50 [PATCH 0/2] powerpc: i2c-mpc: make I2C bus speed configurable Wolfgang Grandegger
2009-03-31 12:50 ` [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking Wolfgang Grandegger
2009-03-31 13:39 ` Wolfram Sang
2009-03-31 13:47 ` Wolfgang Grandegger
2009-03-31 13:56 ` Wolfram Sang [this message]
2009-03-31 15:44 ` Grant Likely
2009-03-31 20:05 ` Wolfgang Grandegger
2009-04-01 0:41 ` PowerPC 460EX AD7416 Temperature Sensor Henry Bausley
2009-04-01 2:10 ` Tirumala Reddy Marri
2009-03-31 12:50 ` [PATCH 2/2] powerpc: i2c-mpc: make I2C bus speed configurable Wolfgang Grandegger
-- strict thread matches above, loose matches on Subject: below --
2009-03-31 12:43 [PATCH 0/2] test Wolfgang Grandegger
2009-03-31 12:43 ` [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking Wolfgang Grandegger
2009-03-31 23:06 ` David Gibson
2009-04-01 7:40 ` Wolfgang Grandegger
2009-04-02 0:07 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090331135629.GC3044@pengutronix.de \
--to=w.sang@pengutronix$(echo .)de \
--cc=devicetree-discuss@ozlabs$(echo .)org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=wg@grandegger$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox