From: Wolfgang Grandegger <wg@grandegger•com>
To: Wolfgang Grandegger <wg@grandegger•com>,
linuxppc-dev@ozlabs•org, devicetree-discuss@ozlabs•org
Subject: Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking
Date: Wed, 01 Apr 2009 09:40:13 +0200 [thread overview]
Message-ID: <49D31A5D.8030204@grandegger.com> (raw)
In-Reply-To: <20090331230626.GB23304@yookeroo.seuss>
David Gibson wrote:
> On Tue, Mar 31, 2009 at 02:43:39PM +0200, Wolfgang Grandegger wrote:
>> The I2c node property "fsl,preserve-clocking" allows to overtake the
>> clock settings from the boot loader and avoids the hard-coded setting.
>
> Hrm. This is dubious. The device tree should generally describe
> hardware, not OS/driver behaviour which is what this appears to be
> doing. There are exceptions, but you need to justify them.
I think the purpose of this property is clear. How would you provide
that functionality instead? I suggested that a "clock-frequency = <0>"
property should do the trick but Grant preferred to be more explicit.
Wolfgang.
next prev parent reply other threads:[~2009-04-01 7:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 12:43 [PATCH 0/2] test Wolfgang Grandegger
2009-03-31 12:43 ` [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking Wolfgang Grandegger
2009-03-31 23:06 ` David Gibson
2009-04-01 7:40 ` Wolfgang Grandegger [this message]
2009-04-02 0:07 ` David Gibson
2009-03-31 12:43 ` [PATCH 2/2] powerpc: i2c-mpc: make I2C bus speed configurable Wolfgang Grandegger
-- strict thread matches above, loose matches on Subject: below --
2009-03-31 12:50 [PATCH 0/2] " Wolfgang Grandegger
2009-03-31 12:50 ` [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking Wolfgang Grandegger
2009-03-31 13:39 ` Wolfram Sang
2009-03-31 13:47 ` Wolfgang Grandegger
2009-03-31 13:56 ` Wolfram Sang
2009-03-31 15:44 ` Grant Likely
2009-03-31 20:05 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D31A5D.8030204@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=devicetree-discuss@ozlabs$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox