From: David Brownell <david-b@pacbell•net>
To: "Steven A. Falco" <sfalco@harris•com>
Cc: "linuxppc-dev@ozlabs•org" <linuxppc-dev@ozlabs•org>,
Stefan Roese <sr@denx•de>
Subject: Re: Subject: [PATCH v8] spi: Add PPC4xx SPI driver
Date: Thu, 2 Jul 2009 17:44:27 -0700 [thread overview]
Message-ID: <200907021744.27636.david-b@pacbell.net> (raw)
In-Reply-To: <4A44F643.3050505@harris.com>
On Friday 26 June 2009, Steven A. Falco wrote:
> +
> + /*
> + * If there are no chip selects at all, or if this is the special
> + * case of a non-existent (dummy) chip select, do nothing.
> + */
> +
> + if (!hw->master->num_chipselect || hw->gpios[cs] == -EEXIST)
> + return;
> +
I'm going to send this in, but please send a followup
patch making all this "non-existent (dummy) chip select"
stuff use the SPI_NO_CS flag.
> + /*
> + * A count of zero implies a single SPI device without any chip-select.
> + * Note that of_gpio_count counts all gpios assigned to this spi master.
> + * This includes both "null" gpio's and real ones.
> + */
next prev parent reply other threads:[~2009-07-03 0:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 16:24 Subject: [PATCH v8] spi: Add PPC4xx SPI driver Steven A. Falco
2009-07-03 0:44 ` David Brownell [this message]
2009-07-06 16:19 ` Steven A. Falco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907021744.27636.david-b@pacbell.net \
--to=david-b@pacbell$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sfalco@harris$(echo .)com \
--cc=sr@denx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox