* [PATCH] USB: FHCI: cq_get() should check kfifo_out()'s return value
@ 2010-05-02 17:30 Anton Vorontsov
2010-05-04 19:17 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Anton Vorontsov @ 2010-05-02 17:30 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linuxppc-dev, linux-usb
Since commit 7acd72eb85f1c7a15e8b5eb554994949241737f1 ("kfifo: rename
kfifo_put... into kfifo_in... and kfifo_get... into kfifo_out..."),
kfifo_out() is marked __must_check, and that causes gcc to produce
lots of warnings like this:
CC drivers/usb/host/fhci-mem.o
In file included from drivers/usb/host/fhci-hcd.c:34:
drivers/usb/host/fhci.h: In function 'cq_get':
drivers/usb/host/fhci.h:520: warning: ignoring return value of 'kfifo_out', declared with attribute warn_unused_result
...
Fix it with BUG_ON() check. We could just forcibly ignore return
value, but it's better to check if we really got a whole pointer.
Signed-off-by: Anton Vorontsov <avorontsov@mvista•com>
---
drivers/usb/host/fhci.h | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/fhci.h b/drivers/usb/host/fhci.h
index 72dae1c..a3fd0fd 100644
--- a/drivers/usb/host/fhci.h
+++ b/drivers/usb/host/fhci.h
@@ -20,6 +20,7 @@
#include <linux/kernel.h>
#include <linux/types.h>
+#include <linux/bug.h>
#include <linux/spinlock.h>
#include <linux/interrupt.h>
#include <linux/kfifo.h>
@@ -515,9 +516,12 @@ static inline int cq_put(struct kfifo *kfifo, void *p)
static inline void *cq_get(struct kfifo *kfifo)
{
+ unsigned int sz;
void *p = NULL;
- kfifo_out(kfifo, (void *)&p, sizeof(p));
+ sz = kfifo_out(kfifo, (void *)&p, sizeof(p));
+ BUG_ON(sz != sizeof(p));
+
return p;
}
--
1.7.0.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] USB: FHCI: cq_get() should check kfifo_out()'s return value
2010-05-02 17:30 [PATCH] USB: FHCI: cq_get() should check kfifo_out()'s return value Anton Vorontsov
@ 2010-05-04 19:17 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2010-05-04 19:17 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev, Greg Kroah-Hartman, linux-usb
On Sun, May 02, 2010 at 09:30:25PM +0400, Anton Vorontsov wrote:
> Since commit 7acd72eb85f1c7a15e8b5eb554994949241737f1 ("kfifo: rename
> kfifo_put... into kfifo_in... and kfifo_get... into kfifo_out..."),
> kfifo_out() is marked __must_check, and that causes gcc to produce
> lots of warnings like this:
>
> CC drivers/usb/host/fhci-mem.o
> In file included from drivers/usb/host/fhci-hcd.c:34:
> drivers/usb/host/fhci.h: In function 'cq_get':
> drivers/usb/host/fhci.h:520: warning: ignoring return value of 'kfifo_out', declared with attribute warn_unused_result
> ...
>
> Fix it with BUG_ON() check. We could just forcibly ignore return
> value, but it's better to check if we really got a whole pointer.
No, you don't want to crash the whole machine for something like this.
Please just handle the error normally and pass it up to the upper levels
if possible.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-04 19:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-02 17:30 [PATCH] USB: FHCI: cq_get() should check kfifo_out()'s return value Anton Vorontsov
2010-05-04 19:17 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox