* [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS @ 2011-09-23 19:32 Anatolij Gustschin 2011-09-25 17:06 ` Tabi Timur-B04825 2011-10-12 4:53 ` Kumar Gala 0 siblings, 2 replies; 14+ messages in thread From: Anatolij Gustschin @ 2011-09-23 19:32 UTC (permalink / raw) To: Kumar Gala, linuxppc-dev Remove wrong CONFIG_ prefix in Kconfig file. Signed-off-by: Anatolij Gustschin <agust@denx•de> --- arch/powerpc/platforms/85xx/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig index 1b393f4..b29d4f2 100644 --- a/arch/powerpc/platforms/85xx/Kconfig +++ b/arch/powerpc/platforms/85xx/Kconfig @@ -80,7 +80,7 @@ config P1010_RDB config P1022_DS bool "Freescale P1022 DS" select DEFAULT_UIMAGE - select CONFIG_PHYS_64BIT # The DTS has 36-bit addresses + select PHYS_64BIT # The DTS has 36-bit addresses select SWIOTLB help This option enables support for the Freescale P1022DS reference board. -- 1.7.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS 2011-09-23 19:32 [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS Anatolij Gustschin @ 2011-09-25 17:06 ` Tabi Timur-B04825 2011-09-26 22:12 ` Kumar Gala 2011-10-12 4:53 ` Kumar Gala 1 sibling, 1 reply; 14+ messages in thread From: Tabi Timur-B04825 @ 2011-09-25 17:06 UTC (permalink / raw) To: Anatolij Gustschin; +Cc: linuxppc-dev@lists•ozlabs.org On Fri, Sep 23, 2011 at 2:32 PM, Anatolij Gustschin <agust@denx•de> wrote: > diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms= /85xx/Kconfig > index 1b393f4..b29d4f2 100644 > --- a/arch/powerpc/platforms/85xx/Kconfig > +++ b/arch/powerpc/platforms/85xx/Kconfig > @@ -80,7 +80,7 @@ config P1010_RDB > =A0config P1022_DS > =A0 =A0 =A0 =A0bool "Freescale P1022 DS" > =A0 =A0 =A0 =A0select DEFAULT_UIMAGE > - =A0 =A0 =A0 select CONFIG_PHYS_64BIT =A0 =A0 =A0 =A0# The DTS has 36-bi= t addresses > + =A0 =A0 =A0 select PHYS_64BIT =A0 =A0 =A0 # The DTS has 36-bit addresse= s I have no idea how this happened, but I wonder if it's a good idea. On the Freescale BSP, the default config for the P1022DS is 32-bit, not 36-bit, so one day we might have a 32-bit config in the upstream repository. PHYS_64BIT is already covered by the defconfig. I wonder if we should just delete the bad line, and let the defconfig select the address size. --=20 Timur Tabi Linux kernel developer at Freescale= ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS 2011-09-25 17:06 ` Tabi Timur-B04825 @ 2011-09-26 22:12 ` Kumar Gala 2011-09-26 22:14 ` Timur Tabi 2011-09-26 22:24 ` Scott Wood 0 siblings, 2 replies; 14+ messages in thread From: Kumar Gala @ 2011-09-26 22:12 UTC (permalink / raw) To: Tabi Timur-B04825; +Cc: Anatolij Gustschin, linuxppc-dev@lists•ozlabs.org On Sep 25, 2011, at 12:06 PM, Tabi Timur-B04825 wrote: > On Fri, Sep 23, 2011 at 2:32 PM, Anatolij Gustschin <agust@denx•de> = wrote: >=20 >> diff --git a/arch/powerpc/platforms/85xx/Kconfig = b/arch/powerpc/platforms/85xx/Kconfig >> index 1b393f4..b29d4f2 100644 >> --- a/arch/powerpc/platforms/85xx/Kconfig >> +++ b/arch/powerpc/platforms/85xx/Kconfig >> @@ -80,7 +80,7 @@ config P1010_RDB >> config P1022_DS >> bool "Freescale P1022 DS" >> select DEFAULT_UIMAGE >> - select CONFIG_PHYS_64BIT # The DTS has 36-bit = addresses >> + select PHYS_64BIT # The DTS has 36-bit addresses >=20 > I have no idea how this happened, but I wonder if it's a good idea. > On the Freescale BSP, the default config for the P1022DS is 32-bit, > not 36-bit, so one day we might have a 32-bit config in the upstream > repository. >=20 > PHYS_64BIT is already covered by the defconfig. I wonder if we should > just delete the bad line, and let the defconfig select the address > size. Why, the way this patch makes it will work both with a 32-bit or 36-bit = address map. The comment should be fixed since its wrong. - k= ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS 2011-09-26 22:12 ` Kumar Gala @ 2011-09-26 22:14 ` Timur Tabi 2011-09-26 22:24 ` Scott Wood 1 sibling, 0 replies; 14+ messages in thread From: Timur Tabi @ 2011-09-26 22:14 UTC (permalink / raw) To: Kumar Gala; +Cc: Anatolij Gustschin, linuxppc-dev@lists•ozlabs.org Kumar Gala wrote: > Why, the way this patch makes it will work both with a 32-bit or 36-bit address map. The comment should be fixed since its wrong. I think the BSP team had said that there is a significant performance improvement in some benchmark when 36-bit support is disabled. That's why they like to keep 32-bit and 36-bit environments for both, and why they default to 32-bit. -- Timur Tabi Linux kernel developer at Freescale ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS 2011-09-26 22:12 ` Kumar Gala 2011-09-26 22:14 ` Timur Tabi @ 2011-09-26 22:24 ` Scott Wood 1 sibling, 0 replies; 14+ messages in thread From: Scott Wood @ 2011-09-26 22:24 UTC (permalink / raw) To: Kumar Gala Cc: linuxppc-dev@lists•ozlabs.org, Anatolij Gustschin, Tabi Timur-B04825 On 09/26/2011 05:12 PM, Kumar Gala wrote: > > On Sep 25, 2011, at 12:06 PM, Tabi Timur-B04825 wrote: > >> On Fri, Sep 23, 2011 at 2:32 PM, Anatolij Gustschin <agust@denx•de> wrote: >> >>> diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig >>> index 1b393f4..b29d4f2 100644 >>> --- a/arch/powerpc/platforms/85xx/Kconfig >>> +++ b/arch/powerpc/platforms/85xx/Kconfig >>> @@ -80,7 +80,7 @@ config P1010_RDB >>> config P1022_DS >>> bool "Freescale P1022 DS" >>> select DEFAULT_UIMAGE >>> - select CONFIG_PHYS_64BIT # The DTS has 36-bit addresses >>> + select PHYS_64BIT # The DTS has 36-bit addresses >> >> I have no idea how this happened, but I wonder if it's a good idea. >> On the Freescale BSP, the default config for the P1022DS is 32-bit, >> not 36-bit, so one day we might have a 32-bit config in the upstream >> repository. >> >> PHYS_64BIT is already covered by the defconfig. I wonder if we should >> just delete the bad line, and let the defconfig select the address >> size. > > Why, the way this patch makes it will work both with a 32-bit or 36-bit address map. The comment should be fixed since its wrong. "select" should not be used for things that you think make good defaults. It should be used for things that are required. It's just like "depends on", except for user interface considerations (and the whole transitive dependency mess). -Scott ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS 2011-09-23 19:32 [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS Anatolij Gustschin 2011-09-25 17:06 ` Tabi Timur-B04825 @ 2011-10-12 4:53 ` Kumar Gala 2011-10-13 14:14 ` Tabi Timur-B04825 1 sibling, 1 reply; 14+ messages in thread From: Kumar Gala @ 2011-10-12 4:53 UTC (permalink / raw) To: Anatolij Gustschin; +Cc: linuxppc-dev On Sep 23, 2011, at 2:32 PM, Anatolij Gustschin wrote: > Remove wrong CONFIG_ prefix in Kconfig file. > > Signed-off-by: Anatolij Gustschin <agust@denx•de> > --- > arch/powerpc/platforms/85xx/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) applied - k ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS 2011-10-12 4:53 ` Kumar Gala @ 2011-10-13 14:14 ` Tabi Timur-B04825 2011-10-13 15:31 ` Kumar Gala 0 siblings, 1 reply; 14+ messages in thread From: Tabi Timur-B04825 @ 2011-10-13 14:14 UTC (permalink / raw) To: Kumar Gala; +Cc: Anatolij Gustschin, linuxppc-dev@lists•ozlabs.org On Tue, Oct 11, 2011 at 11:53 PM, Kumar Gala <galak@kernel•crashing.org> wr= ote: > > On Sep 23, 2011, at 2:32 PM, Anatolij Gustschin wrote: > >> Remove wrong CONFIG_ prefix in Kconfig file. >> >> Signed-off-by: Anatolij Gustschin <agust@denx•de> >> --- >> arch/powerpc/platforms/85xx/Kconfig | =A0 =A02 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > applied Why did you apply this patch? Both Scott and I rejected it. --=20 Timur Tabi Linux kernel developer at Freescale= ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS 2011-10-13 14:14 ` Tabi Timur-B04825 @ 2011-10-13 15:31 ` Kumar Gala 2011-10-13 15:35 ` Timur Tabi 0 siblings, 1 reply; 14+ messages in thread From: Kumar Gala @ 2011-10-13 15:31 UTC (permalink / raw) To: Tabi Timur-B04825; +Cc: Anatolij Gustschin, linuxppc-dev@lists•ozlabs.org On Oct 13, 2011, at 9:14 AM, Tabi Timur-B04825 wrote: > On Tue, Oct 11, 2011 at 11:53 PM, Kumar Gala = <galak@kernel•crashing.org> wrote: >>=20 >> On Sep 23, 2011, at 2:32 PM, Anatolij Gustschin wrote: >>=20 >>> Remove wrong CONFIG_ prefix in Kconfig file. >>>=20 >>> Signed-off-by: Anatolij Gustschin <agust@denx•de> >>> --- >>> arch/powerpc/platforms/85xx/Kconfig | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>=20 >> applied >=20 > Why did you apply this patch? Both Scott and I rejected it. Because its fixing a real issue. If we want to remove PHYS_64BIT = support or make it optional for the board feel free to send another = patch. - k= ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS 2011-10-13 15:31 ` Kumar Gala @ 2011-10-13 15:35 ` Timur Tabi 2011-10-13 15:41 ` Kumar Gala 2011-10-13 15:50 ` Anatolij Gustschin 0 siblings, 2 replies; 14+ messages in thread From: Timur Tabi @ 2011-10-13 15:35 UTC (permalink / raw) To: Kumar Gala; +Cc: Anatolij Gustschin, linuxppc-dev@lists•ozlabs.org Kumar Gala wrote: >> > Why did you apply this patch? Both Scott and I rejected it. > Because its fixing a real issue. If we want to remove PHYS_64BIT support or make it optional for the board feel free to send another patch. Ok, so if someone posts a patch that works but does things the wrong way, and that patch gets rejected during reviews, but the submitter doesn't post a follow-up patch that does things the right way, you're going to apply the first patch anyway? What about the BSP team's contention that enabling 64-bit support in the kernel can drop performance by up to 25% in some situations? We talked about that on an internal mailing list several months ago. -- Timur Tabi Linux kernel developer at Freescale ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS 2011-10-13 15:35 ` Timur Tabi @ 2011-10-13 15:41 ` Kumar Gala 2011-10-13 15:45 ` Timur Tabi 2011-10-13 15:50 ` Anatolij Gustschin 1 sibling, 1 reply; 14+ messages in thread From: Kumar Gala @ 2011-10-13 15:41 UTC (permalink / raw) To: Timur Tabi; +Cc: Anatolij Gustschin, linuxppc-dev@lists•ozlabs.org On Oct 13, 2011, at 10:35 AM, Timur Tabi wrote: > Kumar Gala wrote: >>>> Why did you apply this patch? Both Scott and I rejected it. >=20 >> Because its fixing a real issue. If we want to remove PHYS_64BIT = support or make it optional for the board feel free to send another = patch. >=20 > Ok, so if someone posts a patch that works but does things the wrong = way, and > that patch gets rejected during reviews, but the submitter doesn't = post a > follow-up patch that does things the right way, you're going to apply = the first > patch anyway? Leaving the code 'broken' I consider worse than slightly improving the = situation which the patch does. The original patch for this board port = introduced it with CONFIG_PHYS_64BIT set, thus I think it reasonable to = take a patch that fixed an issue w/o anyone else putting out a patch. If you really don't want it selected by default send me a patch to = remove it and I'll apply. That is far more productive than this = discussion. > What about the BSP team's contention that enabling 64-bit support in = the kernel > can drop performance by up to 25% in some situations? We talked about = that on > an internal mailing list several months ago. I think this 25% number is bogus. There are cases where it also = improves performance. - k= ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS 2011-10-13 15:41 ` Kumar Gala @ 2011-10-13 15:45 ` Timur Tabi 2011-10-13 15:52 ` Anatolij Gustschin 0 siblings, 1 reply; 14+ messages in thread From: Timur Tabi @ 2011-10-13 15:45 UTC (permalink / raw) To: Kumar Gala; +Cc: Anatolij Gustschin, linuxppc-dev@lists•ozlabs.org Kumar Gala wrote: > I think this 25% number is bogus. There are cases where it also improves performance. I don't think we ever ship a P1022 system with more than 2GB of DDR, so I can't see how performance is ever improved. I will post a patch that removes the Kconfig option, but I don't understand why you couldn't do that when you applied the patch. -- Timur Tabi Linux kernel developer at Freescale ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS 2011-10-13 15:45 ` Timur Tabi @ 2011-10-13 15:52 ` Anatolij Gustschin 0 siblings, 0 replies; 14+ messages in thread From: Anatolij Gustschin @ 2011-10-13 15:52 UTC (permalink / raw) To: Timur Tabi; +Cc: linuxppc-dev@lists•ozlabs.org On Thu, 13 Oct 2011 10:45:04 -0500 Timur Tabi <timur@freescale•com> wrote: > Kumar Gala wrote: > > I think this 25% number is bogus. There are cases where it also improves performance. > > I don't think we ever ship a P1022 system with more than 2GB of DDR, so I can't > see how performance is ever improved. > > I will post a patch that removes the Kconfig option, but I don't understand why > you couldn't do that when you applied the patch. please also post a patch providing a working 32bit address map DTS for this board, then. Anatolij ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS 2011-10-13 15:35 ` Timur Tabi 2011-10-13 15:41 ` Kumar Gala @ 2011-10-13 15:50 ` Anatolij Gustschin 2011-10-13 15:59 ` Timur Tabi 1 sibling, 1 reply; 14+ messages in thread From: Anatolij Gustschin @ 2011-10-13 15:50 UTC (permalink / raw) To: Timur Tabi; +Cc: linuxppc-dev@lists•ozlabs.org On Thu, 13 Oct 2011 10:35:04 -0500 Timur Tabi <timur@freescale•com> wrote: > Kumar Gala wrote: > >> > Why did you apply this patch? Both Scott and I rejected it. > > > Because its fixing a real issue. If we want to remove PHYS_64BIT support or make it optional for the board feel free to send another patch. > > Ok, so if someone posts a patch that works but does things the wrong way, and > that patch gets rejected during reviews, but the submitter doesn't post a > follow-up patch that does things the right way, you're going to apply the first > patch anyway? there is no 32bit address map DTS file for P1022DS in the mainline tree. A proper patch should then also add appropriate 32bit address map DTS file. I'm not in the position to do it currently since it would require testing, I do not have this board to test patches for it. Anatolij ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS 2011-10-13 15:50 ` Anatolij Gustschin @ 2011-10-13 15:59 ` Timur Tabi 0 siblings, 0 replies; 14+ messages in thread From: Timur Tabi @ 2011-10-13 15:59 UTC (permalink / raw) To: Anatolij Gustschin; +Cc: linuxppc-dev@lists•ozlabs.org Anatolij Gustschin wrote: > there is no 32bit address map DTS file for P1022DS in the mainline > tree. A proper patch should then also add appropriate 32bit address > map DTS file. I'm not in the position to do it currently since it would > require testing, I do not have this board to test patches for it. The defconfig already enables CONFIG_PHYS_64BIT for the P1022DS and all other 85xx parts. If you look at the Kconfig, you'll see that most boards don't enable it. So by default, everything is 64-bit capable. Adding the Kconfig option will *prevent* anyone from creating a 32-bit kernel. This is my problem with the patch. -- Timur Tabi Linux kernel developer at Freescale ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2011-10-13 15:59 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-09-23 19:32 [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS Anatolij Gustschin 2011-09-25 17:06 ` Tabi Timur-B04825 2011-09-26 22:12 ` Kumar Gala 2011-09-26 22:14 ` Timur Tabi 2011-09-26 22:24 ` Scott Wood 2011-10-12 4:53 ` Kumar Gala 2011-10-13 14:14 ` Tabi Timur-B04825 2011-10-13 15:31 ` Kumar Gala 2011-10-13 15:35 ` Timur Tabi 2011-10-13 15:41 ` Kumar Gala 2011-10-13 15:45 ` Timur Tabi 2011-10-13 15:52 ` Anatolij Gustschin 2011-10-13 15:50 ` Anatolij Gustschin 2011-10-13 15:59 ` Timur Tabi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox