From: Peter Zijlstra <peterz@infradead•org>
To: Shrikanth Hegde <sshegde@linux•ibm.com>
Cc: Christophe Leroy <christophe.leroy@csgroup•eu>,
K Prateek Nayak <kprateek.nayak@amd•com>,
Madhavan Srinivasan <maddy@linux•ibm.com>,
Michael Ellerman <mpe@ellerman•id.au>,
Nicholas Piggin <npiggin@gmail•com>,
Heiko Carstens <hca@linux•ibm.com>,
Vasily Gorbik <gor@linux•ibm.com>,
Alexander Gordeev <agordeev@linux•ibm.com>,
Christian Borntraeger <borntraeger@linux•ibm.com>,
Sven Schnelle <svens@linux•ibm.com>,
Thomas Gleixner <tglx@linutronix•de>,
Ingo Molnar <mingo@redhat•com>, Borislav Petkov <bp@alien8•de>,
Dave Hansen <dave.hansen@linux•intel.com>,
x86@kernel•org, "H. Peter Anvin" <hpa@zytor•com>,
Juri Lelli <juri.lelli@redhat•com>,
Vincent Guittot <vincent.guittot@linaro•org>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
linux-s390@vger•kernel.org,
Dietmar Eggemann <dietmar.eggemann@arm•com>,
Steven Rostedt <rostedt@goodmis•org>,
Ben Segall <bsegall@google•com>, Mel Gorman <mgorman@suse•de>,
Valentin Schneider <vschneid@redhat•com>,
thomas.weissschuh@linutronix•de,
Li Chen <chenl311@chinatelecom•cn>,
Bibo Mao <maobibo@loongson•cn>, Mete Durlu <meted@linux•ibm.com>,
Tobias Huschle <huschle@linux•ibm.com>,
Easwar Hariharan <easwar.hariharan@linux•microsoft.com>,
Guo Weikang <guoweikang.kernel@gmail•com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel•com>,
Brian Gerst <brgerst@gmail•com>,
Patryk Wlazlyn <patryk.wlazlyn@linux•intel.com>,
Swapnil Sapkal <swapnil.sapkal@amd•com>,
"Yury Norov [NVIDIA]" <yury.norov@gmail•com>,
Sudeep Holla <sudeep.holla@arm•com>,
Jonathan Cameron <Jonathan.Cameron@huawei•com>,
Andrea Righi <arighi@nvidia•com>,
Yicong Yang <yangyicong@hisilicon•com>,
Ricardo Neri <ricardo.neri-calderon@linux•intel.com>,
Tim Chen <tim.c.chen@linux•intel.com>,
Vinicius Costa Gomes <vinicius.gomes@intel•com>
Subject: Re: [PATCH v7 4/8] powerpc/smp: Introduce CONFIG_SCHED_MC to guard MC scheduling bits
Date: Mon, 1 Sep 2025 10:35:07 +0200 [thread overview]
Message-ID: <20250901083507.GD4067720@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <7137972e-bc7a-432c-94be-755ba9029d8c@linux.ibm.com>
On Thu, Aug 28, 2025 at 08:13:51PM +0530, Shrikanth Hegde wrote:
> > --- a/arch/powerpc/Kconfig
> > +++ b/arch/powerpc/Kconfig
> > @@ -170,6 +170,9 @@ config PPC
> > select ARCH_STACKWALK
> > select ARCH_SUPPORTS_ATOMIC_RMW
> > select ARCH_SUPPORTS_DEBUG_PAGEALLOC if PPC_BOOK3S || PPC_8xx
> > + select ARCH_SUPPORTS_SCHED_SMT if PPC64 && SMP
> > + select ARCH_SUPPORTS_SCHED_MC if PPC64 && SMP
> > + select SCHED_MC if ARCH_SUPPORTS_SCHED_MC
>
> Wondering if this SCHED_MC is necessary here? shouldn't it be set by arch/Kconfig?
Ah, so without this SCHED_MC becomes a user selectable option, with this
it is an always on option (for ppc64) -- no user prompt.
That is, this is the only way I found to have similar semantics to this:
> > -config SCHED_MC
> > - def_bool y
> > - depends on PPC64 && SMP
> > -
Which is also not a user selectable option.
> nit: Also, can we have so they are still sorted?
> select ARCH_SUPPORTS_SCHED_MC if PPC64 && SMP
> select ARCH_SUPPORTS_SCHED_SMT if PPC64 && SMP
Sure, let me flip them. I need to prod that that patch anyway, built
robot still ain'ted happy.
> > --- a/arch/s390/Kconfig
> > +++ b/arch/s390/Kconfig
> > @@ -547,15 +547,11 @@ config NODES_SHIFT
> > depends on NUMA
> > default "1"
> > -config SCHED_SMT
> > - def_bool n
> > -
> > -config SCHED_MC
> > - def_bool n
> > -
> > config SCHED_TOPOLOGY
> > def_bool y
> > prompt "Topology scheduler support"
> > + select ARCH_SUPPORTS_SCHED_SMT
> > + select ARCH_SUPPORTS_SCHED_MC
> > select SCHED_SMT
> > select SCHED_MC
> Same here. Above two are needed?
Same issue; previously neither were user selectable symbols. By only
selecting the ARCH_SUPPORTS_$FOO variants, the $FOO options become user
selectable. By then explicitly selecting $FOO as well, that user option
is taken away again.
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -330,6 +330,10 @@ config X86
> > imply IMA_SECURE_AND_OR_TRUSTED_BOOT if EFI
> > select HAVE_DYNAMIC_FTRACE_NO_PATCHABLE
> > select ARCH_SUPPORTS_PT_RECLAIM if X86_64
> > + select ARCH_SUPPORTS_SCHED_SMT if SMP
> > + select SCHED_SMT if SMP
> Is this SCHED_SMT needed here?
Same again...
> > + select ARCH_SUPPORTS_SCHED_CLUSTER if SMP
> > + select ARCH_SUPPORTS_SCHED_MC if SMP
> > config INSTRUCTION_DECODER
> > def_bool y
> > @@ -1036,29 +1040,6 @@ config NR_CPUS
> > This is purely to save memory: each supported CPU adds about 8KB
> > to the kernel image.
> > -config SCHED_CLUSTER
> > - bool "Cluster scheduler support"
> > - depends on SMP
> > - default y
> > - help
> > - Cluster scheduler support improves the CPU scheduler's decision
> > - making when dealing with machines that have clusters of CPUs.
> > - Cluster usually means a couple of CPUs which are placed closely
> > - by sharing mid-level caches, last-level cache tags or internal
> > - busses.
> > -
> > -config SCHED_SMT
> > - def_bool y if SMP
> > -
> > -config SCHED_MC
> > - def_bool y
> > - prompt "Multi-core scheduler support"
> > - depends on SMP
> > - help
> > - Multi-core scheduler support improves the CPU scheduler's decision
> > - making when dealing with multi-core CPU chips at a cost of slightly
> > - increased overhead in some places. If unsure say N here.
See how SCHED_SMT is not a user option for x86.
next prev parent reply other threads:[~2025-09-01 8:35 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 4:13 [PATCH v7 0/8] sched/fair: Get rid of sched_domains_curr_level hack for tl->cpumask() K Prateek Nayak
2025-08-26 4:13 ` [PATCH v7 1/8] " K Prateek Nayak
2025-08-28 23:06 ` Tim Chen
2025-08-26 4:13 ` [PATCH v7 2/8] powerpc/smp: Rename cpu_corgroup_* to cpu_corgrp_* K Prateek Nayak
2025-08-26 5:02 ` Christophe Leroy
2025-09-01 3:05 ` K Prateek Nayak
2025-08-26 4:13 ` [PATCH v7 3/8] powerpc/smp: Export cpu_coregroup_mask() K Prateek Nayak
2025-08-26 4:54 ` Christophe Leroy
2025-08-26 4:13 ` [PATCH v7 4/8] powerpc/smp: Introduce CONFIG_SCHED_MC to guard MC scheduling bits K Prateek Nayak
2025-08-26 4:49 ` Christophe Leroy
2025-08-26 8:07 ` Peter Zijlstra
2025-08-26 9:43 ` Peter Zijlstra
2025-08-26 9:59 ` Peter Zijlstra
2025-08-28 14:43 ` Shrikanth Hegde
2025-09-01 8:35 ` Peter Zijlstra [this message]
2025-09-01 8:52 ` Peter Zijlstra
2025-10-14 9:25 ` Geert Uytterhoeven
2025-10-14 9:42 ` Peter Zijlstra
2025-10-14 12:37 ` Geert Uytterhoeven
2025-10-14 14:17 ` Peter Zijlstra
2025-10-14 15:04 ` Geert Uytterhoeven
2025-08-26 9:27 ` Shrikanth Hegde
2025-09-01 4:50 ` K Prateek Nayak
2025-08-26 4:13 ` [PATCH v7 5/8] sched/topology: Unify tl_smt_mask() across core and all arch K Prateek Nayak
2025-08-26 5:13 ` Christophe Leroy
2025-08-26 8:01 ` Peter Zijlstra
2025-08-26 8:11 ` Christophe Leroy
2025-08-26 8:24 ` Peter Zijlstra
2025-08-26 4:13 ` [PATCH v7 6/8] sched/topology: Unify tl_cls_mask() across core and x86 K Prateek Nayak
2025-08-26 5:14 ` Christophe Leroy
2025-08-26 4:13 ` [PATCH v7 7/8] sched/topology: Unify tl_mc_mask() across core and all arch K Prateek Nayak
2025-08-26 5:15 ` Christophe Leroy
2025-08-26 4:13 ` [PATCH v7 8/8] sched/topology: Unify tl_pkg_mask() " K Prateek Nayak
2025-08-26 5:16 ` Christophe Leroy
2025-08-26 10:05 ` [PATCH v7 0/8] sched/fair: Get rid of sched_domains_curr_level hack for tl->cpumask() Shrikanth Hegde
2025-08-26 10:13 ` Peter Zijlstra
2025-08-29 7:53 ` Valentin Schneider
2025-08-29 8:53 ` Shrikanth Hegde
2025-09-01 4:39 ` K Prateek Nayak
2025-09-01 8:58 ` Peter Zijlstra
2025-09-01 17:06 ` Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250901083507.GD4067720@noisy.programming.kicks-ass.net \
--to=peterz@infradead$(echo .)org \
--cc=Jonathan.Cameron@huawei$(echo .)com \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=arighi@nvidia$(echo .)com \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=bp@alien8$(echo .)de \
--cc=brgerst@gmail$(echo .)com \
--cc=bsegall@google$(echo .)com \
--cc=chenl311@chinatelecom$(echo .)cn \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=dietmar.eggemann@arm$(echo .)com \
--cc=easwar.hariharan@linux$(echo .)microsoft.com \
--cc=gor@linux$(echo .)ibm.com \
--cc=guoweikang.kernel@gmail$(echo .)com \
--cc=hca@linux$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=huschle@linux$(echo .)ibm.com \
--cc=juri.lelli@redhat$(echo .)com \
--cc=kprateek.nayak@amd$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=maobibo@loongson$(echo .)cn \
--cc=meted@linux$(echo .)ibm.com \
--cc=mgorman@suse$(echo .)de \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=npiggin@gmail$(echo .)com \
--cc=patryk.wlazlyn@linux$(echo .)intel.com \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=ricardo.neri-calderon@linux$(echo .)intel.com \
--cc=rostedt@goodmis$(echo .)org \
--cc=sshegde@linux$(echo .)ibm.com \
--cc=sudeep.holla@arm$(echo .)com \
--cc=svens@linux$(echo .)ibm.com \
--cc=swapnil.sapkal@amd$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=thomas.weissschuh@linutronix$(echo .)de \
--cc=tim.c.chen@linux$(echo .)intel.com \
--cc=vincent.guittot@linaro$(echo .)org \
--cc=vinicius.gomes@intel$(echo .)com \
--cc=vschneid@redhat$(echo .)com \
--cc=x86@kernel$(echo .)org \
--cc=yangyicong@hisilicon$(echo .)com \
--cc=yury.norov@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox