From: Tim Chen <tim.c.chen@linux•intel.com>
To: K Prateek Nayak <kprateek.nayak@amd•com>,
Madhavan Srinivasan <maddy@linux•ibm.com>,
Michael Ellerman <mpe@ellerman•id.au>,
Nicholas Piggin <npiggin@gmail•com>,
Christophe Leroy <christophe.leroy@csgroup•eu>,
Heiko Carstens <hca@linux•ibm.com>,
Vasily Gorbik <gor@linux•ibm.com>,
Alexander Gordeev <agordeev@linux•ibm.com>,
Christian Borntraeger <borntraeger@linux•ibm.com>,
Sven Schnelle <svens@linux•ibm.com>,
Thomas Gleixner <tglx@linutronix•de>,
Ingo Molnar <mingo@redhat•com>, Borislav Petkov <bp@alien8•de>,
Dave Hansen <dave.hansen@linux•intel.com>,
x86@kernel•org, "H. Peter Anvin" <hpa@zytor•com>,
Peter Zijlstra <peterz@infradead•org>,
Juri Lelli <juri.lelli@redhat•com>,
Vincent Guittot <vincent.guittot@linaro•org>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
linux-s390@vger•kernel.org
Cc: Dietmar Eggemann <dietmar.eggemann@arm•com>,
Steven Rostedt <rostedt@goodmis•org>,
Ben Segall <bsegall@google•com>, Mel Gorman <mgorman@suse•de>,
Valentin Schneider <vschneid@redhat•com>,
thomas.weissschuh@linutronix•de,
Li Chen <chenl311@chinatelecom•cn>,
Bibo Mao <maobibo@loongson•cn>, Mete Durlu <meted@linux•ibm.com>,
Tobias Huschle <huschle@linux•ibm.com>,
Easwar Hariharan <easwar.hariharan@linux•microsoft.com>,
Guo Weikang <guoweikang.kernel@gmail•com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel•com>,
Brian Gerst <brgerst@gmail•com>,
Patryk Wlazlyn <patryk.wlazlyn@linux•intel.com>,
Swapnil Sapkal <swapnil.sapkal@amd•com>,
"Yury Norov [NVIDIA]" <yury.norov@gmail•com>,
Sudeep Holla <sudeep.holla@arm•com>,
Jonathan Cameron <Jonathan.Cameron@huawei•com>,
Andrea Righi <arighi@nvidia•com>,
Yicong Yang <yangyicong@hisilicon•com>,
Ricardo Neri <ricardo.neri-calderon@linux•intel.com>,
Vinicius Costa Gomes <vinicius.gomes@intel•com>
Subject: Re: [PATCH v7 1/8] sched/fair: Get rid of sched_domains_curr_level hack for tl->cpumask()
Date: Thu, 28 Aug 2025 16:06:37 -0700 [thread overview]
Message-ID: <932003e8783cd73c9303044ee17efdad5e3cbd8d.camel@linux.intel.com> (raw)
In-Reply-To: <20250826041319.1284-2-kprateek.nayak@amd.com>
On Tue, 2025-08-26 at 04:13 +0000, K Prateek Nayak wrote:
> From: Peter Zijlstra <peterz@infradead•org>
>
>
...snip...
>
> -static const struct cpumask *cpu_mc_mask(int cpu)
> +static const struct cpumask *cpu_mc_mask(struct sched_domain_topology_level *tl, int cpu)
> {
> return cpu_coregroup_mask(cpu);
> }
>
> +static const struct cpumask *cpu_pkg_mask(struct sched_domain_topology_level *tl, int cpu)
> +{
> + return cpu_node_mask(cpu);
> +}
> +
I suggest that we rename this function as tl_node_mask as we are
returning the node mask. We could have multiple nodes in a package
for SNC and it may not actually be pkg_mask for such case.
Rest of the patch looks good.
Thanks.
Tim
next prev parent reply other threads:[~2025-08-29 0:44 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 4:13 [PATCH v7 0/8] sched/fair: Get rid of sched_domains_curr_level hack for tl->cpumask() K Prateek Nayak
2025-08-26 4:13 ` [PATCH v7 1/8] " K Prateek Nayak
2025-08-28 23:06 ` Tim Chen [this message]
2025-08-26 4:13 ` [PATCH v7 2/8] powerpc/smp: Rename cpu_corgroup_* to cpu_corgrp_* K Prateek Nayak
2025-08-26 5:02 ` Christophe Leroy
2025-09-01 3:05 ` K Prateek Nayak
2025-08-26 4:13 ` [PATCH v7 3/8] powerpc/smp: Export cpu_coregroup_mask() K Prateek Nayak
2025-08-26 4:54 ` Christophe Leroy
2025-08-26 4:13 ` [PATCH v7 4/8] powerpc/smp: Introduce CONFIG_SCHED_MC to guard MC scheduling bits K Prateek Nayak
2025-08-26 4:49 ` Christophe Leroy
2025-08-26 8:07 ` Peter Zijlstra
2025-08-26 9:43 ` Peter Zijlstra
2025-08-26 9:59 ` Peter Zijlstra
2025-08-28 14:43 ` Shrikanth Hegde
2025-09-01 8:35 ` Peter Zijlstra
2025-09-01 8:52 ` Peter Zijlstra
2025-10-14 9:25 ` Geert Uytterhoeven
2025-10-14 9:42 ` Peter Zijlstra
2025-10-14 12:37 ` Geert Uytterhoeven
2025-10-14 14:17 ` Peter Zijlstra
2025-10-14 15:04 ` Geert Uytterhoeven
2025-08-26 9:27 ` Shrikanth Hegde
2025-09-01 4:50 ` K Prateek Nayak
2025-08-26 4:13 ` [PATCH v7 5/8] sched/topology: Unify tl_smt_mask() across core and all arch K Prateek Nayak
2025-08-26 5:13 ` Christophe Leroy
2025-08-26 8:01 ` Peter Zijlstra
2025-08-26 8:11 ` Christophe Leroy
2025-08-26 8:24 ` Peter Zijlstra
2025-08-26 4:13 ` [PATCH v7 6/8] sched/topology: Unify tl_cls_mask() across core and x86 K Prateek Nayak
2025-08-26 5:14 ` Christophe Leroy
2025-08-26 4:13 ` [PATCH v7 7/8] sched/topology: Unify tl_mc_mask() across core and all arch K Prateek Nayak
2025-08-26 5:15 ` Christophe Leroy
2025-08-26 4:13 ` [PATCH v7 8/8] sched/topology: Unify tl_pkg_mask() " K Prateek Nayak
2025-08-26 5:16 ` Christophe Leroy
2025-08-26 10:05 ` [PATCH v7 0/8] sched/fair: Get rid of sched_domains_curr_level hack for tl->cpumask() Shrikanth Hegde
2025-08-26 10:13 ` Peter Zijlstra
2025-08-29 7:53 ` Valentin Schneider
2025-08-29 8:53 ` Shrikanth Hegde
2025-09-01 4:39 ` K Prateek Nayak
2025-09-01 8:58 ` Peter Zijlstra
2025-09-01 17:06 ` Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=932003e8783cd73c9303044ee17efdad5e3cbd8d.camel@linux.intel.com \
--to=tim.c.chen@linux$(echo .)intel.com \
--cc=Jonathan.Cameron@huawei$(echo .)com \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=arighi@nvidia$(echo .)com \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=bp@alien8$(echo .)de \
--cc=brgerst@gmail$(echo .)com \
--cc=bsegall@google$(echo .)com \
--cc=chenl311@chinatelecom$(echo .)cn \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=dietmar.eggemann@arm$(echo .)com \
--cc=easwar.hariharan@linux$(echo .)microsoft.com \
--cc=gor@linux$(echo .)ibm.com \
--cc=guoweikang.kernel@gmail$(echo .)com \
--cc=hca@linux$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=huschle@linux$(echo .)ibm.com \
--cc=juri.lelli@redhat$(echo .)com \
--cc=kprateek.nayak@amd$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=maobibo@loongson$(echo .)cn \
--cc=meted@linux$(echo .)ibm.com \
--cc=mgorman@suse$(echo .)de \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=npiggin@gmail$(echo .)com \
--cc=patryk.wlazlyn@linux$(echo .)intel.com \
--cc=peterz@infradead$(echo .)org \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=ricardo.neri-calderon@linux$(echo .)intel.com \
--cc=rostedt@goodmis$(echo .)org \
--cc=sudeep.holla@arm$(echo .)com \
--cc=svens@linux$(echo .)ibm.com \
--cc=swapnil.sapkal@amd$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=thomas.weissschuh@linutronix$(echo .)de \
--cc=vincent.guittot@linaro$(echo .)org \
--cc=vinicius.gomes@intel$(echo .)com \
--cc=vschneid@redhat$(echo .)com \
--cc=x86@kernel$(echo .)org \
--cc=yangyicong@hisilicon$(echo .)com \
--cc=yury.norov@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox