From: Doug Maxey <dwm@enoyolf•org>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: yaboot-devel@ozlabs•org, Linux PowerPC List <linuxppc-dev@ozlabs•org>
Subject: Re: [PATCH 1/1] determine last ext3 LBA to fix wild LBA reads - v2
Date: Wed, 03 Jan 2007 20:11:21 -0600 [thread overview]
Message-ID: <32402.1167876681@bebe.enoyolf.org> (raw)
In-Reply-To: <1167872956.6165.172.camel@localhost.localdomain>
On Thu, 04 Jan 2007 12:09:16 +1100, Benjamin Herrenschmidt wrote:
> > tempb = (((unsigned long long) block) *
> > ((unsigned long long)bs)) + (unsigned long long)doff;
> > + if (tempb > dend) {
> > + DEBUG_F("\nSeek error on block %lx, tempb=%Lx\n", block, tempb >> 9);
> > + return EXT2_ET_LLSEEK_FAILED;
> > + }
> > +
>
> In the case where we don't pass a "part", dend is 0 no ? We should check
> this case and not apply the test...
well, I guess we should not test in that case. (dend && tempb >> dend)
But that puts us back in the position of searching past the end of the
disk.
On what system would we get here without having found a partition table?
Ext2 on a optical disk?
++doug
next prev parent reply other threads:[~2007-01-04 2:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-03 7:17 [PATCH 1/1] determine last ext3 LBA to fix wild LBA reads - v2 Doug Maxey
2007-01-04 1:09 ` Benjamin Herrenschmidt
2007-01-04 2:11 ` Doug Maxey [this message]
2007-01-04 3:31 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32402.1167876681@bebe.enoyolf.org \
--to=dwm@enoyolf$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=yaboot-devel@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox