From: Armin Kuster <akuster@mvista•com>
To: "David Müller" <d.mueller@elsoft•ch>
Cc: linuxppc-embedded@lists•linuxppc.org
Subject: Re: [PATCH] 3 patches against linuxppc_dev-2.4.18-pre7
Date: Thu, 31 Jan 2002 10:15:46 -0800 [thread overview]
Message-ID: <3C5989D2.3F77685@mvista.com> (raw)
In-Reply-To: 3C59005A.4080400@elsoft.ch
"David Müller (ELSOFT AG)" wrote:
>
> Hi
>
> Armin Kuster wrote:
>
> > "David Müller (ELSOFT AG)" wrote:
> >
> >>Hello
> >>
> >>The attached patch fixes the following issues:
> >>
> >> - arch/ppc/kernel/ppc4xx_pic.c
> >> fixed constant in ppc405_pic_get_irq()
> >> (should be NR_AIC_IRQS as in ppc403_pic_get_irq())
> >>
> >
> > David,
> >
> > include/asm-ppc/irq.h
> > NR_IRQS = (NR_AIC_IRQS + NR_BOARD_IRQS) and was defined to allow
> > cascading UIC's.
> > NR_BOARD_IRQS is defined in some of the board files and its default is
> > in include/asm-ppc/ibm4xx.h
> >
> > So i don't see the need to patch that file but the others look fine.
> >
> >
>
> Exactly, NR_IRQS is the the total number of irqs possible in the system
> as this number of irqs is reserved in the irq_desc table.
>
> For example, we have a system with a PPC405GP and an additional PC like 8259 PIC
> pair, we have NR_AIC_IRQS (32) + NR_BOARD_IRQS (16) = NR_IRQS (48).
>
> In ppc405_pic_get_irq() the following code is executed:
>
> irq = 32 - ffs(bits);
>
> if (irq == NR_IRQS)
> irq = -1;
>
> return(irq);
>
> with NR_IRQS equal 48 the condition is never true !
>
> This results in an endless while-loop in do_IRQ() in arch/ppc/kernel/irq.c
>
> Either this or my understanding how things are working is totally wrong. ;-)
> Additionally, i don't see me why ppc403_pic_get_irq() is using NC_AIC_IRQS while
> ppc405_pic_get_irq() is using NR_IRQS. Shouldn't they be "symmetric".
>
> Dave
David,
your right.
-- armin
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-01-31 18:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-30 13:48 [PATCH] 3 patches against linuxppc_dev-2.4.18-pre7 David Müller (ELSOFT AG)
2002-01-30 18:52 ` Armin Kuster
2002-01-31 8:29 ` David Müller (ELSOFT AG)
2002-01-31 18:15 ` Armin Kuster [this message]
2002-01-31 18:26 ` Mark Pilon
2002-01-31 18:42 ` Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C5989D2.3F77685@mvista.com \
--to=akuster@mvista$(echo .)com \
--cc=d.mueller@elsoft$(echo .)ch \
--cc=linuxppc-embedded@lists$(echo .)linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox