public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Mark Pilon <mpilon@midrivers•com>
To: Armin Kuster <akuster@mvista•com>
Cc: "David Müller" <d.mueller@elsoft•ch>,
	linuxppc-embedded@lists•linuxppc.org
Subject: Re: [PATCH] 3 patches against linuxppc_dev-2.4.18-pre7
Date: Thu, 31 Jan 2002 11:26:09 -0700	[thread overview]
Message-ID: <3C598C41.8AC31B3C@midrivers.com> (raw)
In-Reply-To: 3C5989D2.3F77685@mvista.com


> >
> > In ppc405_pic_get_irq() the following code is executed:
> >
> >         irq = 32 - ffs(bits);
> >
> >         if (irq == NR_IRQS)
> >                 irq = -1;
> >
> >         return(irq);
> >
> > with NR_IRQS equal 48 the condition is never true !
> >


You might check the actual code generated for ffs() and verify
it works -- I ended up recoding this routine because ffs() wasn't
working correctly ... [ I forget the particulars, but the code
generated and behavior were not correct ];

Mark
--
Mark Pilon

Minolta-QMS
P.O. Box 37
Fallon, MT.  59326-0037
1-406-486-5539 (primary voice line)
1-406-853-0433 (cell)

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

  reply	other threads:[~2002-01-31 18:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-30 13:48 [PATCH] 3 patches against linuxppc_dev-2.4.18-pre7 David Müller (ELSOFT AG)
2002-01-30 18:52 ` Armin Kuster
2002-01-31  8:29   ` David Müller (ELSOFT AG)
2002-01-31 18:15     ` Armin Kuster
2002-01-31 18:26       ` Mark Pilon [this message]
2002-01-31 18:42         ` Dan Malek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C598C41.8AC31B3C@midrivers.com \
    --to=mpilon@midrivers$(echo .)com \
    --cc=akuster@mvista$(echo .)com \
    --cc=d.mueller@elsoft$(echo .)ch \
    --cc=linuxppc-embedded@lists$(echo .)linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox