From: Pantelis Antoniou <panto@intracom•gr>
To: Dan Malek <dan@embeddededge•com>
Cc: Tom Rini <trini@kernel•crashing.org>,
linuxppc-embedded <linuxppc-embedded@ozlabs•org>
Subject: Re: [PATCH 03/04] Freescale Ethernet combined driver
Date: Tue, 10 May 2005 15:15:39 +0300 [thread overview]
Message-ID: <4280A5EB.4000306@intracom.gr> (raw)
In-Reply-To: <f1e15a8d9ed033e850b56ca965754a43@embeddededge.com>
Dan Malek wrote:
>
> On May 10, 2005, at 7:17 AM, Pantelis Antoniou wrote:
>
>> This patch replace iopa use with virt_to_phys.
>
>
> Not gonna work .....
>
> When you map uncached on 8xx you get a new vmalloc()
> space. The virt_to_xxx macros don't work on those addresses.
> You need to use the dma_consistent() function, stash the
> real physical address it returns and then use it where
> appropriate.
>
Hmm. Correct. The dma_consistent() function will
do some cache flushing, but we don't really care about that
anyway.
Oh well. Patch will be forthcoming...
>> + W32(ep, fen_genfcc.fcc_rbase, virt_to_phys(fep->rx_bd_base));
>> + W32(ep, fen_genfcc.fcc_tbase, virt_to_phys(fep->tx_bd_base));
>
>
> I thought you were getting rid of these weirdo macros and
> write normal code for data structure access? Please .....
>
This is going to be difficult since the /net/drivers maintainer
insists on using them. I used to have direct data structure
accesses so it won't be difficult to change.
But we must have a consunsus.
> Thanks.
>
>
> -- Dan
>
>
>
Regards
Pantelis
next prev parent reply other threads:[~2005-05-10 12:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-09 11:45 [PATCH 03/04] Freescale Ethernet combined driver Pantelis Antoniou
2005-05-09 20:38 ` Matt Porter
2005-05-10 11:17 ` Pantelis Antoniou
2005-05-10 12:13 ` Dan Malek
2005-05-10 12:15 ` Pantelis Antoniou [this message]
2005-05-10 13:27 ` Matt Porter
2005-05-10 13:14 ` Pantelis Antoniou
2005-05-10 13:47 ` Matt Porter
2005-05-10 13:36 ` Pantelis Antoniou
2005-05-12 9:37 ` Pantelis Antoniou
2005-05-13 8:51 ` Pantelis Antoniou
2005-05-10 18:14 ` Dan Malek
-- strict thread matches above, loose matches on Subject: below --
2005-05-10 14:53 Rune Torgersen
2005-05-10 18:24 ` Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4280A5EB.4000306@intracom.gr \
--to=panto@intracom$(echo .)gr \
--cc=dan@embeddededge$(echo .)com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=trini@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox