From: Sergei Shtylyov <sshtylyov@ru•mvista.com>
To: Vitaly Bordug <vbordug@ru•mvista.com>
Cc: linuxppc-dev@ozlabs•org, Paul Mackerras <paulus@samba•org>
Subject: Re: [PATCH 10/11] Add MPC8360EMDS board support
Date: Wed, 27 Sep 2006 18:57:47 +0400 [thread overview]
Message-ID: <451A916B.9010905@ru.mvista.com> (raw)
In-Reply-To: <20060927165556.04c8d5d7@vitb.ru.mvista.com>
Hello.
Vitaly Bordug wrote:
>>>>>+#define BCSR_PHYS_ADDR ((uint)0xf8000000)
>>>>>+#define BCSR_SIZE ((uint)(32 * 1024))
>>>>This sort of thing should really be in the device tree.
>>>Just a suggestion, but for the similar aim in pq2 I have those stuff
>>in memory node :
>>>+memory {
>>>+ device_type = "memory";
>>>+ linux,phandle = <300>;
>>>+ reg = <00000000 4000000 f4500000 00000020>;
>>>+ };
>>>the second pair is about bcsr and its size.
>>>Just in case this may help (and wondering if I'm not violating
>>something :) )
>>Well, this can make it work. But I would prefer to use a new node
>>because the BCSR is by no means a memory type of device. I have made my
>>change to use node like this:
>> bcsr@f8000000 {
>> device_type = "board-control";
>> reg = <f8000000 8000>;
>> };
> I though about that approach, but saw somewhere a reference that we should not summon new node types without utter necessity, and utilized memory because bcsr is memory-mapped stuff.
You might have utilized "memory" even for the Ethernet controllers guided
by such logic. Of course, that was a wrong criterion -- "memory" is for RAM,
otherwise you'd be fooling the kernel device tree scanner which looks for the
"memory" nodes.
> I can hardly imagine bcsr as a device (which would require respective spec inclusion btw).
And this is hardly a memory, neverthless.
WBR, Sergei
next prev parent reply other threads:[~2006-09-27 14:57 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-21 12:20 [PATCH 10/11] Add MPC8360EMDS board support Li Yang
2006-09-27 6:39 ` Paul Mackerras
2006-09-27 11:56 ` Vitaly Bordug
2006-09-27 12:02 ` Li Yang-r58472
2006-09-27 12:55 ` Vitaly Bordug
2006-09-27 13:09 ` Ben Warren
2006-09-27 13:20 ` Li Yang-r58472
2006-09-27 13:33 ` Kumar Gala
2006-09-28 6:12 ` Li Yang-r58472
2006-09-30 0:49 ` Paul Mackerras
2006-09-27 14:14 ` Jon Loeliger
2006-09-28 6:38 ` Li Yang-r58472
2006-09-27 14:42 ` Dan Malek
2006-09-27 16:22 ` Olof Johansson
2006-09-28 4:10 ` Dan Malek
2006-09-30 15:56 ` Li Yang
2006-10-04 0:40 ` Paul Mackerras
2006-10-04 13:53 ` Dan Malek
2006-10-04 17:28 ` Tim Bird
2006-10-05 0:27 ` Paul Mackerras
2006-10-05 6:29 ` Eugene Surovegin
2006-10-04 6:08 ` Benjamin Herrenschmidt
2006-10-04 14:48 ` Dan Malek
2006-10-04 23:36 ` Benjamin Herrenschmidt
2006-10-05 0:03 ` Paul Mackerras
2006-10-05 0:08 ` Benjamin Herrenschmidt
2006-10-05 0:16 ` Vitaly Bordug
2006-10-05 6:21 ` Eugene Surovegin
2006-10-05 6:26 ` Benjamin Herrenschmidt
2006-10-05 6:31 ` Eugene Surovegin
2006-10-05 6:33 ` Eugene Surovegin
2006-10-05 6:51 ` Benjamin Herrenschmidt
2006-10-04 5:52 ` Benjamin Herrenschmidt
2006-10-04 14:57 ` Dan Malek
2006-10-04 16:05 ` Jerry Van Baren
2006-09-27 14:57 ` Sergei Shtylyov [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-09-27 13:54 Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451A916B.9010905@ru.mvista.com \
--to=sshtylyov@ru$(echo .)mvista.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=vbordug@ru$(echo .)mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox