From: Sylvain Munaut <tnt@246tNt•com>
To: Dale Farnsworth <dale@farnsworth•org>
Cc: linuxppc-embedded@ozlabs•org
Subject: Re: [PATCH 1/2] Add MPC52xx Interrupt controller support for ARCH=powerpc
Date: Tue, 31 Oct 2006 00:18:00 +0100 [thread overview]
Message-ID: <45468828.8010200@246tNt.com> (raw)
In-Reply-To: <20061030174724.7155.qmail@farnsworth.org>
Dale Farnsworth wrote:
> In article <200610292310.k9TNAHXZ013852@post•webmailer.de> Nicolas wrote:
>
>> This patch add MPC52xx Interrupt controller for ARCH=powerpc.
>>
>> It includes the main code in arch/powerpc/sysdev/ ad well as an header
>> file in include/asm-powerpc.
>>
>> Signed-off-by: Nicolas DET <nd@bplan-gmbh•de>
>>
>
> NAK.
>
> Two requests:
> 1. Please include patches inline so that they may be easily reviewed.
> 2. Please do not remove copyright lines from files you modify.
>
Indeed.
Dale Farnsworth wrote:
> Wow, the source code size sure ballooned in this revision.
>
> I'd like to see us go the other direction, with something like the
> following (untested code).
>
Well that's kind of a contradiction with what benh asked (separate IC
chips).
> static inline void io_be_setbit(u32 __iomem *addr, int bitno)
> {
> out_be32(addr, in_be32(addr) | 1 << bitno);
> }
>
> static inline void io_be_clrbit(u32 __iomem *addr, int bitno)
> {
> out_be32(addr, in_be32(addr) & ~(1 << bitno));
> }
>
Those could still be used to cleanup a little the code.
Sylvain
next prev parent reply other threads:[~2006-10-30 23:18 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-29 23:10 [PATCH 1/2] Add MPC52xx Interrupt controller support for ARCH=powerpc Nicolas DET
2006-10-30 17:37 ` Dale Farnsworth
2006-10-30 17:47 ` Dale Farnsworth
2006-10-30 23:18 ` Sylvain Munaut [this message]
2006-10-31 7:10 ` Nicolas DET
2006-10-30 22:25 ` Kumar Gala
2006-10-30 22:31 ` Benjamin Herrenschmidt
2006-10-30 23:15 ` Sylvain Munaut
2006-10-31 1:11 ` Kumar Gala
2006-10-31 6:59 ` Sylvain Munaut
2006-10-31 7:05 ` Benjamin Herrenschmidt
2006-10-31 7:14 ` Nicolas DET
2006-10-31 7:38 ` Benjamin Herrenschmidt
2006-10-31 8:25 ` Nicolas DET
2006-10-31 8:42 ` Benjamin Herrenschmidt
2006-10-31 9:08 ` Nicolas DET
2006-10-31 20:04 ` Nicolas DET
2006-10-31 21:59 ` Benjamin Herrenschmidt
2006-10-31 22:08 ` Grant Likely
2006-10-31 22:11 ` Benjamin Herrenschmidt
2006-10-31 23:08 ` Grant Likely
2006-11-01 1:06 ` Benjamin Herrenschmidt
2006-11-01 9:24 ` Nicolas DET
2006-11-01 20:56 ` Benjamin Herrenschmidt
2006-10-31 14:34 ` Kumar Gala
2006-10-31 16:24 ` Grant Likely
2006-10-31 4:27 ` Benjamin Herrenschmidt
2006-10-31 7:09 ` Nicolas DET
2006-10-31 7:21 ` Benjamin Herrenschmidt
2006-10-31 7:49 ` Nicolas DET
2006-10-31 7:58 ` Benjamin Herrenschmidt
2006-10-31 8:28 ` Nicolas DET
2006-10-31 8:44 ` Benjamin Herrenschmidt
2006-10-31 9:04 ` Nicolas DET
2006-10-31 9:07 ` Benjamin Herrenschmidt
2006-10-31 9:46 ` Nicolas DET
2006-10-31 20:29 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45468828.8010200@246tNt.com \
--to=tnt@246tnt$(echo .)com \
--cc=dale@farnsworth$(echo .)org \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox