From: Nicolas DET <nd@bplan-gmbh•de>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, sl@bplan-gmbh•de, sha@pengutronix•de,
linuxppc-embedded@ozlabs•org
Subject: Re: [PATCH 1/2] Add MPC52xx Interrupt controller support for ARCH=powerpc
Date: Tue, 31 Oct 2006 09:25:20 +0100 (MET) [thread overview]
Message-ID: <4547086D.2050808@bplan-gmbh.de> (raw)
In-Reply-To: <1162280335.25682.302.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1970 bytes --]
Benjamin Herrenschmidt wrote:
>> Well, on a personal point of view, the only usable mailer I know does
>> not run on my 'work' OS. I'll copy/paste from an editor ;-)
>
> And both are ? (mailer and 'work' OS ? :)
>
Mailer: SimpleMail. Almost usable a bit buggy.
'work' OS: Linux PowerPC ;-)
>>> +/* MBAR position */
>>> +#define MPC52xx_MBAR 0xf0000000 /* Phys address */
>>> +#define MPC52xx_MBAR_VIRT 0xf0000000 /* Virt address */
>>> +#define MPC52xx_MBAR_SIZE 0x00010000
>>> +
>>> +#define MPC52xx_PA(x) ((phys_addr_t)(MPC52xx_MBAR + (x)))
>>> +#define MPC52xx_VA(x) ((void __iomem *)(MPC52xx_MBAR_VIRT + (x)))
>>>
>>> This should be handled dynamically (pulled from the device tree), I
>>> doubt MBAR will be at the same location for all boards.
>> Well, 0xf000000 seems some kind of 'standart' value. we could have a
>> global variable 'mpc52xx_mbar' which would be default 0xf0000000 and
>> modified by each platform.
>
> No. No magic globals. If we need some common code for dealing with some
> 52xx specific bits, them have a file somewhere, possibly in sysdev,
> containing those and exposing functions.
>
Ok. By the way, the mbar is include as property in our OpenFrimware.
Moreover, the G2CORE CPU has a new SPR 'MBAR' which is the MBAR ;-). It
would maybe make sense to create a new file
(arch/powerpc/sysdev/mpc52xx.c) which would contain chip specific code.
Like mpc52xx_get_mbar(), mpc52xx_get_ipbfreq(), etc...
I updated a bit the patches. I applied Dale requests.
My kernel still compiles and boots. ;-)
Should I post the new patches?
About the headers thingy. Should I split them directly in the patch, or
this should be done by others later on?
About the serials and USB part. Have anyone already do some work (moving
to of_platform, etc...)?
As far as I see, the Efika platform patch did not get any comment,
should I assume it is good enough for inclusion in the main stream kernel?
Regards.
[-- Attachment #2: nd.vcf --]
[-- Type: text/x-vcard, Size: 249 bytes --]
begin:vcard
fn:Nicolas DET ( bplan GmbH )
n:DET;Nicolas
org:bplan GmbH
adr:;;;;;;Germany
email;internet:nd@bplan-gmbh•de
title:Software Entwicklung
tel;work:+49 6171 9187 - 31
x-mozilla-html:FALSE
url:http://www.bplan-gmbh.de
version:2.1
end:vcard
next prev parent reply other threads:[~2006-10-31 8:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-29 23:10 [PATCH 1/2] Add MPC52xx Interrupt controller support for ARCH=powerpc Nicolas DET
2006-10-30 17:37 ` Dale Farnsworth
2006-10-30 17:47 ` Dale Farnsworth
2006-10-30 23:18 ` Sylvain Munaut
2006-10-31 7:10 ` Nicolas DET
2006-10-30 22:25 ` Kumar Gala
2006-10-30 22:31 ` Benjamin Herrenschmidt
2006-10-30 23:15 ` Sylvain Munaut
2006-10-31 1:11 ` Kumar Gala
2006-10-31 6:59 ` Sylvain Munaut
2006-10-31 7:05 ` Benjamin Herrenschmidt
2006-10-31 7:14 ` Nicolas DET
2006-10-31 7:38 ` Benjamin Herrenschmidt
2006-10-31 8:25 ` Nicolas DET [this message]
2006-10-31 8:42 ` Benjamin Herrenschmidt
2006-10-31 9:08 ` Nicolas DET
2006-10-31 20:04 ` Nicolas DET
2006-10-31 21:59 ` Benjamin Herrenschmidt
2006-10-31 22:08 ` Grant Likely
2006-10-31 22:11 ` Benjamin Herrenschmidt
2006-10-31 23:08 ` Grant Likely
2006-11-01 1:06 ` Benjamin Herrenschmidt
2006-11-01 9:24 ` Nicolas DET
2006-11-01 20:56 ` Benjamin Herrenschmidt
2006-10-31 14:34 ` Kumar Gala
2006-10-31 16:24 ` Grant Likely
2006-10-31 4:27 ` Benjamin Herrenschmidt
2006-10-31 7:09 ` Nicolas DET
2006-10-31 7:21 ` Benjamin Herrenschmidt
2006-10-31 7:49 ` Nicolas DET
2006-10-31 7:58 ` Benjamin Herrenschmidt
2006-10-31 8:28 ` Nicolas DET
2006-10-31 8:44 ` Benjamin Herrenschmidt
2006-10-31 9:04 ` Nicolas DET
2006-10-31 9:07 ` Benjamin Herrenschmidt
2006-10-31 9:46 ` Nicolas DET
2006-10-31 20:29 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4547086D.2050808@bplan-gmbh.de \
--to=nd@bplan-gmbh$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=sha@pengutronix$(echo .)de \
--cc=sl@bplan-gmbh$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox