From: Vitaly Wool <vwool@ru•mvista.com>
To: Josh Boyer <jwboyer@linux•vnet.ibm.com>
Cc: linuxppc-embedded@ozlabs•org
Subject: Re: [PATCH] adding ROM chips to device tree
Date: Thu, 02 Nov 2006 16:45:56 +0300 [thread overview]
Message-ID: <4549F694.1050707@ru.mvista.com> (raw)
In-Reply-To: <1162474237.11351.7.camel@zod.rchland.ibm.com>
Josh Boyer wrote:
> On Thu, 2006-11-02 at 14:55 +0300, Vitaly Wool wrote:
>
>> In fact, currently this description can handle only flash devices mapped into memory in a linear way.
>> For NAND flashes we'll need a whole lot different description but let's solve problems as they arise
>> since I'm not aware of any ppc board w/ NAND chip yet :)
>>
>
> Um... all of the 440EP and 440EPx boards have NAND. And those have
> been around for a while...
>
>
Okay, that's nice to know. As you might have noticed, I'm a huge fan of
NAND flashes :)
>> +
>> + Required properties:
>> +
>> + - device_type : has to be "rom"
>>
>
> Why "rom" instead of "NOR"?
>
Hmm, it corresponds to Sergei's version. The latter had this as "mtd"
but following the thread I preferred to give it a more generic name.
However, thinking of it now, I realize that "NOR" is probably better
since we'll have to define another set of properties for NAND (which
will be of type "NAND" then) :)
>
>> + - compatible : Should be the name of the MTD driver. Currently, this is
>> + most likely to be "physmap".
>> + - reg : Offset and length of the register set for the device.
>>
>
> reg doesn't really describe a register set here. It's the overall
> memory space for flash.
>
Absolutely. Basically the description was just taken from Sergei's patch
with minimal modifications :)
>
>> +
>> + Recommended properties :
>> +
>> + - bank-width : Width of the flash data bus in bytes. Must be specified
>> + for the NOR flashes.
>>
>
> This is a required property, not a recommended one.
>
Yea, better have it in a separate section.
Thanks,
Vitaly
next prev parent reply other threads:[~2006-11-02 13:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-02 11:55 [PATCH] adding ROM chips to device tree Vitaly Wool
2006-11-02 13:30 ` Josh Boyer
2006-11-02 13:45 ` Vitaly Wool [this message]
2006-11-02 19:09 ` Sergei Shtylyov
2006-11-02 20:23 ` Vitaly Wool
2006-11-07 18:29 ` Sergei Shtylyov
2006-11-02 15:31 ` Grant Likely
2006-11-02 15:53 ` Vitaly Wool
2006-11-02 19:01 ` Sergei Shtylyov
2006-11-02 20:30 ` Vitaly Wool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4549F694.1050707@ru.mvista.com \
--to=vwool@ru$(echo .)mvista.com \
--cc=jwboyer@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox