From: Sergei Shtylyov <sshtylyov@ru•mvista.com>
To: Josh Boyer <jwboyer@linux•vnet.ibm.com>,
Vitaly Wool <vwool@ru•mvista.com>
Cc: linuxppc-embedded@ozlabs•org
Subject: Re: [PATCH] adding ROM chips to device tree
Date: Tue, 07 Nov 2006 21:29:54 +0300 [thread overview]
Message-ID: <4550D0A2.90509@ru.mvista.com> (raw)
In-Reply-To: <454A4266.8040505@ru.mvista.com>
Sergei Shtylyov wrote:
> Hello.
>
> Josh Boyer wrote:
>
>
>>>+
>>>+ Required properties:
>>>+
>>>+ - device_type : has to be "rom"
>>Why "rom" instead of "NOR"?
> What does "NOR" mean -- logical operator? :-)
> I'd yet agree with "nor-flash", however, the physmap-driven device may not
> always be writeable, IIUC...
Hence an idea: maybe we need to introduce the "writeable" property (just a
logical value, i.e. absent/resent)?
>>>+ - compatible : Should be the name of the MTD driver. Currently, this is
>>>+ most likely to be "physmap".
>>>+ - reg : Offset and length of the register set for the device.
>>reg doesn't really describe a register set here. It's the overall
>>memory space for flash.
Since "reg" property is the way for device to claim its I/O resources, it
must be used to describe the decoded memory range, I think. Maybe I should
have added a comment about its meaning for direct mapped devices in the first
place...
> This is no more a standard boilerplate, if you look at this file.
No more than a boilerplate, I meant to say.
WBR, Sergei
next prev parent reply other threads:[~2006-11-07 18:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-02 11:55 [PATCH] adding ROM chips to device tree Vitaly Wool
2006-11-02 13:30 ` Josh Boyer
2006-11-02 13:45 ` Vitaly Wool
2006-11-02 19:09 ` Sergei Shtylyov
2006-11-02 20:23 ` Vitaly Wool
2006-11-07 18:29 ` Sergei Shtylyov [this message]
2006-11-02 15:31 ` Grant Likely
2006-11-02 15:53 ` Vitaly Wool
2006-11-02 19:01 ` Sergei Shtylyov
2006-11-02 20:30 ` Vitaly Wool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4550D0A2.90509@ru.mvista.com \
--to=sshtylyov@ru$(echo .)mvista.com \
--cc=jwboyer@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=vwool@ru$(echo .)mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox