From: Sergei Shtylyov <sshtylyov@ru•mvista.com>
To: Timur Tabi <timur@freescale•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc: automatically select QE options
Date: Mon, 28 May 2007 21:43:14 +0400 [thread overview]
Message-ID: <465B14B2.2020804@ru.mvista.com> (raw)
In-Reply-To: <1173732027723-git-send-email-timur@freescale.com>
Hello.
Timur Tabi wrote:
> Change the Kconfig files so that the Freescale QE options are automatically
> selected if a QE device is selected. Previously, you'd need to manually
> select UCC_FAST if you want any "fast" UCC devices, such as Gigabit Ethernet.
> Now, the QE Gigabit Ethernet option is always available if the device has a
> QE, and UCC_FAST is automatically enabled. A side-effect is that the
> "QE Options" menu no longer exists.
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index d9400ef..b92a4e6 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2272,11 +2272,12 @@ config GFAR_NAPI
> depends on GIANFAR
>
> config UCC_GETH
> - tristate "Freescale QE UCC GETH"
> - depends on QUICC_ENGINE && UCC_FAST
> + tristate "Freescale QE Gigabit Ethernet"
> + depends on QUICC_ENGINE
> + select UCC_FAST
Grr... this causes menuconfig to complain on non-PPC archs:
drivers/net/Kconfig:2278:warning: 'select' used by config symbol 'UCC_GETH'
refer to undefined symbol 'UCC_FAST'
WBR, Sergei
next prev parent reply other threads:[~2007-05-28 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 20:40 [PATCH] powerpc: automatically select QE options Timur Tabi
2007-03-13 10:24 ` Li Yang-r58472
2007-03-13 14:38 ` Kumar Gala
2007-03-14 18:15 ` Kumar Gala
2007-05-28 17:43 ` Sergei Shtylyov [this message]
2007-05-29 0:20 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465B14B2.2020804@ru.mvista.com \
--to=sshtylyov@ru$(echo .)mvista.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox