From: Geoff Levand <geoffrey.levand@am•sony.com>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: linuxppc-dev <linuxppc-dev@ozlabs•org>,
Paul Mackerras <paulus@samba•org>, Arnd Bergmann <arnd@arndb•de>
Subject: Re: PS3: Fix build with 32-bit toolchains
Date: Thu, 19 Jul 2007 15:36:13 -0700 [thread overview]
Message-ID: <469FE75D.6000402@am.sony.com> (raw)
In-Reply-To: <A127B558-BA1C-4F18-890B-7052F2DF7488@kernel.crashing.org>
Kumar Gala wrote:
> On Jul 19, 2007, at 4:47 PM, Geoff Levand wrote:
>
>> The PS3 bootwrapper files use instructions only available on
>> 64-bit CPUs. Add the code generation directive '.machine "ppc64"'
>> for toolchains configured for 32-bit CPUs.
>>
>> Signed-off-by: Geoff Levand <geoffrey.levand@am•sony.com>
>
> while this is a fix, why are we even building it Grant's case of
> building 834x itx.
I originally had the makefile setup to conditionally build these
files on CONFIG_PPC_PS3, but during the review I was requested to
change it to build them unconditionally. See:
http://ozlabs.org/pipermail/linuxppc-dev/2007-June/038072.html
-Geoff
next prev parent reply other threads:[~2007-07-19 22:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 19:49 BUG: compile failure on ps3-head.S Grant Likely
2007-07-19 21:45 ` Segher Boessenkool
2007-07-19 21:47 ` PS3: Fix build with 32-bit toolchains Geoff Levand
2007-07-19 22:05 ` Kumar Gala
2007-07-19 22:36 ` Geoff Levand [this message]
2007-07-19 22:16 ` Grant Likely
2007-07-20 15:31 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469FE75D.6000402@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=arnd@arndb$(echo .)de \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox