From: Geoff Levand <geoffrey.levand@am•sony.com>
To: akpm@linux-foundation•org
Cc: linuxppc-dev <linuxppc-dev@ozlabs•org>,
Paul Mackerras <paulus@samba•org>, Arnd Bergmann <arnd@arndb•de>
Subject: PS3: Fix build with 32-bit toolchains
Date: Fri, 20 Jul 2007 08:31:21 -0700 [thread overview]
Message-ID: <46A0D549.1020108@am.sony.com> (raw)
In-Reply-To: <469FDBDC.5030700@am.sony.com>
The PS3 bootwrapper files use instructions only available on
64-bit CPUs. Add the code generation directive '.machine "ppc64"'
for toolchains configured for 32-bit CPUs.
Signed-off-by: Geoff Levand <geoffrey.levand@am•sony.com>
Acked-by: Grant Likely <grant.likely@secretlab•ca>
---
Hi Andrew,
It seems Paul is out on holiday, so I'm sending this to you.
This fixes a build error in Linus' current tree for a few
32 bit powerpc platforms. It had some review on the
linuxppc-dev ML, and Grant Likely reported it fixed the
problem.
-Geoff
arch/powerpc/boot/ps3-head.S | 2 ++
arch/powerpc/boot/ps3-hvcall.S | 2 ++
2 files changed, 4 insertions(+)
--- a/arch/powerpc/boot/ps3-head.S
+++ b/arch/powerpc/boot/ps3-head.S
@@ -20,6 +20,8 @@
#include "ppc_asm.h"
+ .machine "ppc64"
+
.text
/*
--- a/arch/powerpc/boot/ps3-hvcall.S
+++ b/arch/powerpc/boot/ps3-hvcall.S
@@ -20,6 +20,8 @@
#include "ppc_asm.h"
+ .machine "ppc64"
+
/*
* The PS3 hypervisor uses a 64 bit "C" language calling convention.
* The routines here marshal arguments between the 32 bit wrapper
prev parent reply other threads:[~2007-07-20 15:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 19:49 BUG: compile failure on ps3-head.S Grant Likely
2007-07-19 21:45 ` Segher Boessenkool
2007-07-19 21:47 ` PS3: Fix build with 32-bit toolchains Geoff Levand
2007-07-19 22:05 ` Kumar Gala
2007-07-19 22:36 ` Geoff Levand
2007-07-19 22:16 ` Grant Likely
2007-07-20 15:31 ` Geoff Levand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A0D549.1020108@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox